From: Martyn Welch <martyn.welch@collabora•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>,
Bjorn Andersson <andersson@kernel•org>,
Mathieu Poirier <mathieu.poirier@linaro•org>,
Jassi Brar <jassisinghbrar@gmail•com>
Cc: Andrew Davis <afd@ti•com>, Hari Nagalla <hnagalla@ti•com>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: Re: linux-next: build warning after merge of the rpmsg tree
Date: Wed, 28 Aug 2024 10:45:20 +0100 [thread overview]
Message-ID: <57440a796530c153cd0ee3e7b11c2fbab9887fbf.camel@collabora.com> (raw)
In-Reply-To: <20240828150900.7ffd7588@canb.auug.org.au>
On Wed, 2024-08-28 at 15:09 +1000, Stephen Rothwell wrote:
> Hi all,
>
> On Thu, 22 Aug 2024 14:26:03 +1000 Stephen Rothwell
> <sfr@canb•auug.org.au> wrote:
> >
> > After merging the rpmsg tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> >
> > WARNING: unmet direct dependencies detected for OMAP2PLUS_MBOX
> > Depends on [n]: MAILBOX [=y] && (ARCH_OMAP2PLUS || ARCH_K3)
> > Selected by [m]:
> > - TI_K3_M4_REMOTEPROC [=m] && REMOTEPROC [=y] && (ARCH_K3 ||
> > COMPILE_TEST [=y])
> >
> > Probably introduced by commit
> >
> > ebcf9008a895 ("remoteproc: k3-m4: Add a remoteproc driver for M4F
> > subsystem")
>
> I am still seeing this warning.
>
OK, just taken a look into this. I think the issue is the result of the
inclusion of `COMPILE_TEST` in the Kconfig entry:
config TI_K3_M4_REMOTEPROC
tristate "TI K3 M4 remoteproc support"
depends on ARCH_K3 || COMPILE_TEST
select MAILBOX
select OMAP2PLUS_MBOX
...
Looking at the entry for `OMAP2PLUS_MBOX`, that doesn't have
`COMPILE_TEST` listed under it's dependencies:
config OMAP2PLUS_MBOX
tristate "OMAP2+ Mailbox framework support"
depends on ARCH_OMAP2PLUS || ARCH_K3
...
If I understand right, either the `COMPILE_TEST` needs to be removed
from `TI_K3_M4_REMOTEPROC` or added to `OMAP2PLUS_MBOX`.
It appears that the OMAP2+ Mailbox support can at least be compiled on
x86_64. so I assume the correct thing to do here is to enable that
right?
Jassi, I assume there's not specific reason for the OMAP2+ Mailbox
framework support not having `COMPILE_TEST`, other than potentially
being added just before it was a thing?
Martyn
next prev parent reply other threads:[~2024-08-28 9:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 4:26 linux-next: build warning after merge of the rpmsg tree Stephen Rothwell
2024-08-28 5:09 ` Stephen Rothwell
2024-08-28 9:45 ` Martyn Welch [this message]
2024-09-01 20:12 ` Jassi Brar
2024-09-06 8:36 ` Stephen Rothwell
2024-09-06 8:58 ` Martyn Welch
2024-09-12 8:34 ` Stephen Rothwell
2024-09-12 14:15 ` Jassi Brar
2024-09-12 15:32 ` Martyn Welch
2024-09-18 5:28 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2017-06-27 4:43 Stephen Rothwell
2017-06-27 23:47 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57440a796530c153cd0ee3e7b11c2fbab9887fbf.camel@collabora.com \
--to=martyn.welch@collabora$(echo .)com \
--cc=afd@ti$(echo .)com \
--cc=andersson@kernel$(echo .)org \
--cc=hnagalla@ti$(echo .)com \
--cc=jassisinghbrar@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mathieu.poirier@linaro$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox