From: Mason <slash.tmp@free•fr>
To: Stephen Rothwell <sfr@canb•auug.org.au>,
Russell King <rmk@armlinux•org.uk>,
Vinod Koul <vinod.koul@intel•com>,
Dan Williams <dan.j.williams@intel•com>
Cc: linux-next <linux-next@vger•kernel.org>,
LKML <linux-kernel@vger•kernel.org>,
Linux ARM <linux-arm-kernel@lists•infradead.org>,
arm-soc <arm@kernel•org>, Emilio Lopez <emilio@elopez•com.ar>,
dmaengine@vger•kernel.org,
Maxime Ripard <maxime.ripard@free-electrons•com>,
Chen-Yu Tsai <wens@csie•org>
Subject: [PATCH] dmaengine: sun4i: fix invalid argument
Date: Fri, 21 Apr 2017 10:06:10 +0200 [thread overview]
Message-ID: <584a2c53-100b-945b-d665-cef3fa856526@free.fr> (raw)
In-Reply-To: <9858a4ed-bdd9-bd6c-d8a4-e9e6bd539904@free.fr>
The "pchans_used" field is an unsigned long array.
for_each_clear_bit_from() expects an unsigned long pointer,
not an array address.
$ make C=2 drivers/dma/sun4i-dma.o
CHECK drivers/dma/sun4i-dma.c
drivers/dma/sun4i-dma.c:241:9: warning: incorrect type in argument 1 (different base types)
drivers/dma/sun4i-dma.c:241:9: expected unsigned long const *p
drivers/dma/sun4i-dma.c:241:9: got unsigned long ( *<noident> )[1]
Signed-off-by: Mason <slash.tmp@free•fr>
---
drivers/dma/sun4i-dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/sun4i-dma.c b/drivers/dma/sun4i-dma.c
index 57aa227bfadb..f4ed3f17607c 100644
--- a/drivers/dma/sun4i-dma.c
+++ b/drivers/dma/sun4i-dma.c
@@ -238,7 +238,7 @@ static struct sun4i_dma_pchan *find_and_use_pchan(struct sun4i_dma_dev *priv,
}
spin_lock_irqsave(&priv->lock, flags);
- for_each_clear_bit_from(i, &priv->pchans_used, max) {
+ for_each_clear_bit_from(i, priv->pchans_used, max) {
pchan = &pchans[i];
pchan->vchan = vchan;
set_bit(i, priv->pchans_used);
--
3.14159
next prev parent reply other threads:[~2017-04-21 8:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 22:40 linux-next: build failure after merge of the arm tree Stephen Rothwell
2017-04-21 7:58 ` Mason
2017-04-21 8:06 ` Mason [this message]
2017-04-21 8:24 ` [PATCH] dmaengine: sun4i: fix invalid argument Maxime Ripard
2017-04-21 8:43 ` [PATCH v2] " Mason
2017-04-21 14:40 ` Maxime Ripard
2017-04-21 8:12 ` linux-next: build failure after merge of the arm tree Stephen Rothwell
2017-04-21 8:30 ` Mason
2017-04-21 23:43 ` Russell King - ARM Linux
2017-04-22 8:41 ` Mason
2017-04-24 4:20 ` Vinod Koul
2017-04-26 22:34 ` [PATCH v2] arm: bitops: Align prototypes to generic API Mason
2017-06-14 19:23 ` linux-next: build failure after merge of the arm tree Mason
2017-04-21 11:27 ` Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=584a2c53-100b-945b-d665-cef3fa856526@free.fr \
--to=slash.tmp@free$(echo .)fr \
--cc=arm@kernel$(echo .)org \
--cc=dan.j.williams@intel$(echo .)com \
--cc=dmaengine@vger$(echo .)kernel.org \
--cc=emilio@elopez$(echo .)com.ar \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=maxime.ripard@free-electrons$(echo .)com \
--cc=rmk@armlinux$(echo .)org.uk \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=vinod.koul@intel$(echo .)com \
--cc=wens@csie$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox