From: "Aithal, Srikanth" <sraithal@amd•com>
To: paulmck@kernel•org
Cc: Bert Karwatzki <spasswolf@web•de>,
Andrew Morton <akpm@linux-foundation•org>,
Kuniyuki Iwashima <kuniyu@amazon•com>,
Mateusz Guzik <mjguzik@gmail•com>, Petr Mladek <pmladek@suse•com>,
Steven Rostedt <rostedt@goodmis•org>,
John Ogness <john.ogness@linutronix•de>,
Sergey Senozhatsky <senozhatsky@chromium•org>,
linux-kernel@vger•kernel.org,
Linux-Next Mailing List <linux-next@vger•kernel.org>
Subject: Re: commit dd4cf8c9e1f4 leads to failed boot
Date: Wed, 23 Apr 2025 20:49:08 +0530 [thread overview]
Message-ID: <5a4a3d0d-a2e1-4fd3-acd2-3ae12a2ac7b0@amd.com> (raw)
In-Reply-To: <fa8dd394-45c1-48d3-881c-5f3d5422df39@paulmck-laptop>
On 4/23/2025 7:48 PM, Paul E. McKenney wrote:
> On Wed, Apr 23, 2025 at 07:09:42PM +0530, Aithal, Srikanth wrote:
>> On 4/23/2025 5:24 PM, Bert Karwatzki wrote:
>>> Since linux next-20250422 booting fails on my MSI Alpha 15 Laptop runnning
>>> debian sid. When booting kernel message appear on screen but no messages from
>>> init (systemd). There are also no logs written even thought emergency sync
>>> via magic sysrq works (a message is printed on screen), presumably because
>>> / is not mounted. I bisected this (from 6.15-rc3 to next-20250422) and found
>>> commit dd4cf8c9e1f4 as the first bad commit.
>>> Reverting commit dd4cf8c9e1f4 in next-20250422 fixes the issue.
>>
>>
>> Hello,
>>
>> On AMD platform as well boot failed starting next-20250422, bisecting the
>> issue led me to same commit dd4cf8c9e1f4. I have attached kernel config and
>> logs.
>
> Thank you all for the bisection and the report!
>
> Please check out the predecessor of commit dd4cf8c9e1f4 ("ratelimit:
> Force re-initialization when rate-limiting re-enabled"):
>
> 13fa70e052dd ("ratelimit: Allow zero ->burst to disable ratelimiting")
>
> Then please apply the patch shown below, and let me know what happens?
> (Yes, I should have split that commit up...)
>
> Thanx, Paul
>
> ------------------------------------------------------------------------
>
> diff --git a/lib/ratelimit.c b/lib/ratelimit.c
> index 04f16b8e24575..13ed636642270 100644
> --- a/lib/ratelimit.c
> +++ b/lib/ratelimit.c
> @@ -35,7 +35,7 @@ int ___ratelimit(struct ratelimit_state *rs, const char *func)
> unsigned long flags;
> int ret;
>
> - if (!interval || !burst)
> + if (interval <= 0 || burst <= 0)
> return 1;
>
> /*
I applied above patch on top of 13fa70e052dd ("ratelimit: Allow zero
->burst to disable ratelimiting") [linux-20250423]. This is fixing the
boot issue.
Tested-by: Srikanth Aithal <sraithal@amd•com>
next prev parent reply other threads:[~2025-04-23 15:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250423115409.3425-1-spasswolf@web.de>
2025-04-23 13:39 ` commit dd4cf8c9e1f4 leads to failed boot Aithal, Srikanth
2025-04-23 13:46 ` Steven Rostedt
2025-04-23 13:47 ` Aithal, Srikanth
2025-04-23 14:01 ` Steven Rostedt
2025-04-23 14:02 ` Steven Rostedt
2025-04-23 14:18 ` Paul E. McKenney
2025-04-23 14:59 ` Bert Karwatzki
2025-04-23 18:03 ` Bert Karwatzki
2025-04-23 15:19 ` Aithal, Srikanth [this message]
2025-04-23 18:07 ` Paul E. McKenney
2025-04-23 19:19 ` Bert Karwatzki
2025-04-23 19:56 ` Paul E. McKenney
2025-04-24 4:30 ` Aithal, Srikanth
2025-04-24 7:36 ` Petr Mladek
2025-04-24 14:43 ` Paul E. McKenney
2025-04-25 9:35 ` Petr Mladek
2025-04-25 16:34 ` Paul E. McKenney
2025-04-24 12:40 ` Bert Karwatzki
2025-04-24 14:30 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a4a3d0d-a2e1-4fd3-acd2-3ae12a2ac7b0@amd.com \
--to=sraithal@amd$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=john.ogness@linutronix$(echo .)de \
--cc=kuniyu@amazon$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mjguzik@gmail$(echo .)com \
--cc=paulmck@kernel$(echo .)org \
--cc=pmladek@suse$(echo .)com \
--cc=rostedt@goodmis$(echo .)org \
--cc=senozhatsky@chromium$(echo .)org \
--cc=spasswolf@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox