From: Paolo Bonzini <pbonzini@redhat•com>
To: Eric Biggers <ebiggers3@gmail•com>, kvm@vger•kernel.org
Cc: rkrcmar@redhat•com, tianyu.lan@intel•com,
christoffer.dall@linaro•org, x86@kernel•org,
linux-kernel@vger•kernel.org, syzkaller-bugs@googlegroups•com,
Eric Biggers <ebiggers@google•com>,
Stephen Rothwell <sfr@canb•auug.org.au>,
Linux-Next Mailing List <linux-next@vger•kernel.org>
Subject: Re: [PATCH linux-next] KVM: x86: don't forget vcpu_put() in kvm_arch_vcpu_ioctl_set_sregs()
Date: Thu, 21 Dec 2017 01:30:30 +0100 [thread overview]
Message-ID: <5e98adf7-809f-3b98-e8fc-6ba89e2777cf@redhat.com> (raw)
In-Reply-To: <20171221002427.82325-1-ebiggers3@gmail.com>
On 21/12/2017 01:24, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google•com>
>
> Due to a bad merge resolution between commit f29810335965 ("KVM/x86:
> Check input paging mode when cs.l is set") and commit b4ef9d4e8cb8
> ("KVM: Move vcpu_load to arch-specific kvm_arch_vcpu_ioctl_set_sregs"),
> there is a case in kvm_arch_vcpu_ioctl_set_sregs() where vcpu_put() is
> not called after vcpu_get(). Fix it.
>
> Reported-by: syzbot <syzkaller@googlegroups•com>
> Signed-off-by: Eric Biggers <ebiggers@google•com>
> ---
> arch/x86/kvm/x86.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index ea3a98196753..f4e8b5089b28 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -7624,7 +7624,7 @@ int kvm_arch_vcpu_ioctl_set_sregs(struct kvm_vcpu *vcpu,
> goto out;
>
> if (kvm_valid_sregs(vcpu, sregs))
> - return -EINVAL;
> + goto out;
>
> apic_base_msr.data = sregs->apic_base;
> apic_base_msr.host_initiated = true;
>
Thanks very much Eric, that was fast! Adding Stephen and the linux-next
mailing list to Cc. Adding the kvm/master tree has already paid off.
Paolo
next parent reply other threads:[~2017-12-21 0:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <001a1148cc3acf967c0560c7b760@google.com>
[not found] ` <20171221002427.82325-1-ebiggers3@gmail.com>
2017-12-21 0:30 ` Paolo Bonzini [this message]
2017-12-21 1:02 ` [PATCH linux-next] KVM: x86: don't forget vcpu_put() in kvm_arch_vcpu_ioctl_set_sregs() Stephen Rothwell
2017-12-21 2:45 ` Lan Tianyu
2017-12-21 9:07 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e98adf7-809f-3b98-e8fc-6ba89e2777cf@redhat.com \
--to=pbonzini@redhat$(echo .)com \
--cc=christoffer.dall@linaro$(echo .)org \
--cc=ebiggers3@gmail$(echo .)com \
--cc=ebiggers@google$(echo .)com \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=rkrcmar@redhat$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=syzkaller-bugs@googlegroups$(echo .)com \
--cc=tianyu.lan@intel$(echo .)com \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox