From: Shuah Khan <skhan@linuxfoundation•org>
To: Kees Cook <keescook@chromium•org>, Shuah Khan <shuah@kernel•org>
Cc: Hangbin Liu <liuhangbin@gmail•com>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger•kernel.org>,
Jonathan Corbet <corbet@lwn•net>,
Naresh Kamboju <naresh.kamboju@linaro•org>,
linux-doc@vger•kernel.org,
open list <linux-kernel@vger•kernel.org>,
Tim.Bird@sony•com, lkft-triage@lists•linaro.org,
Anders Roxell <anders.roxell@linaro•org>,
Justin Cook <justin.cook@linaro•org>,
Linux-Next Mailing List <linux-next@vger•kernel.org>,
Shuah Khan <skhan@linuxfoundation•org>
Subject: Re: [PATCHv5 kselftest next] selftests/run_kselftest.sh: make each test individually selectable
Date: Fri, 25 Sep 2020 16:37:45 -0600 [thread overview]
Message-ID: <659b23c9-abf5-0387-c4c6-5d0a48e3afdc@linuxfoundation.org> (raw)
In-Reply-To: <202009251414.15274C0@keescook>
On 9/25/20 3:16 PM, Kees Cook wrote:
> On Fri, Sep 25, 2020 at 01:51:53PM +0530, Naresh Kamboju wrote:
>> On Mon, 14 Sep 2020 at 07:53, Hangbin Liu <liuhangbin@gmail•com> wrote:
>>>
>>> Currently, after generating run_kselftest.sh, there is no way to choose
>>> which test we could run. All the tests are listed together and we have
>>> to run all every time. This patch enhanced the run_kselftest.sh to make
>>> the tests individually selectable. e.g.
>>>
>>> $ ./run_kselftest.sh -t "bpf size timers"
>>
>> My test run break on linux next
>>
>> ./run_kselftest.sh: line 1331: syntax error near unexpected token `)'
>> ./run_kselftest.sh: line 1331: `-e -s | --summary )
>> logfile=$BASE_DIR/output.log; cat /dev/null > $logfile; shift ;;'
>
> Yes, please revert this patch. The resulting script is completely
> trashed:
>
> BASE_DIR=$(realpath $(dirname $0))
> . ./kselftest/runner.sh
> TESTS="seccomp"
>
> run_seccomp()
> {
> -e [ -w /dev/kmsg ] && echo "kselftest: Running tests in seccomp" >> /dev/kmsg
> -e cd seccomp
> -en run_many
> \
> -ne "seccomp_bpf"
> \
> -ne "seccomp_benchmark"
>
> -e cd $ROOT
> }
>
>
>
Will do.
thanks,
-- Shuah
next prev parent reply other threads:[~2020-09-25 22:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200914021758.420874-1-liuhangbin@gmail.com/>
[not found] ` <20200914022227.437143-1-liuhangbin@gmail.com>
2020-09-25 8:21 ` [PATCHv5 kselftest next] selftests/run_kselftest.sh: make each test individually selectable Naresh Kamboju
2020-09-25 21:16 ` Kees Cook
2020-09-25 22:37 ` Shuah Khan [this message]
2020-09-25 23:06 ` Shuah Khan
2020-09-25 23:46 ` Kees Cook
2020-09-27 1:53 ` Hangbin Liu
2020-09-28 20:06 ` Kees Cook
2020-09-29 1:27 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=659b23c9-abf5-0387-c4c6-5d0a48e3afdc@linuxfoundation.org \
--to=skhan@linuxfoundation$(echo .)org \
--cc=Tim.Bird@sony$(echo .)com \
--cc=anders.roxell@linaro$(echo .)org \
--cc=corbet@lwn$(echo .)net \
--cc=justin.cook@linaro$(echo .)org \
--cc=keescook@chromium$(echo .)org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=liuhangbin@gmail$(echo .)com \
--cc=lkft-triage@lists$(echo .)linaro.org \
--cc=naresh.kamboju@linaro$(echo .)org \
--cc=shuah@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox