From: <dan.j.williams@intel•com>
To: "Thomas Weißschuh" <linux@weissschuh•net>,
"Cedric Xing" <cedric.xing@intel•com>
Cc: <dan.j.williams@intel•com>, <sfr@canb•auug.org.au>,
<sathyanarayanan.kuppuswamy@linux•intel.com>,
<yilun.xu@intel•com>, <sameo@rivosinc•com>, <aik@amd•com>,
<suzuki.poulose@arm•com>, <steven.price@arm•com>,
<lukas@wunner•de>, <greg@kroah•com>, <linux-next@vger•kernel.org>
Subject: Re: [PATCH v2] tsm-mr: Fix init breakage after bin_attrs constification by scoping non-const pointers to init phase
Date: Tue, 13 May 2025 10:27:53 -0700 [thread overview]
Message-ID: <682381198ad46_49706100fe@dwillia2-mobl4.notmuch> (raw)
In-Reply-To: <ee550446-ef6f-4fd1-bffd-cc09f82bd883@t-8ch.de>
Thomas Weißschuh wrote:
> On 2025-05-13 11:41:54-0500, Cedric Xing wrote:
> > Commit 9bec944506fa ("sysfs: constify attribute_group::bin_attrs") enforced
> > the ro-after-init principle by making elements of bin_attrs_new pointing to
> > const.
> >
> > To align with this change, introduce a temporary variable `bap` within the
> > initialization loop. This improves code clarity by explicitly marking the
> > initialization scope and eliminates the need for type casts when assigning
> > to bin_attrs_new.
> >
> > Signed-off-by: Cedric Xing <cedric.xing@intel•com>
> > ---
> > drivers/virt/coco/tsm-mr.c | 30 +++++++++++++++---------------
> > 1 file changed, 15 insertions(+), 15 deletions(-)
>
> <snip>
>
> > @@ -244,7 +244,7 @@ EXPORT_SYMBOL_GPL(tsm_mr_create_attribute_group);
> > void tsm_mr_free_attribute_group(const struct attribute_group *attr_grp)
> > {
> > if (!IS_ERR_OR_NULL(attr_grp)) {
> > - kfree(attr_grp->bin_attrs);
> > + kfree(attr_grp->bin_attrs_new);
>
> This is good, but the assignment also needs to be done to .bin_attrs_new.
> That is the code I can find on LKML:
> https://lore.kernel.org/lkml/20250506-tdx-rtmr-v6-1-ac6ff5e9d58a@intel.com/
Oh, the latest fixup that preceded this only went to linux-coco:
http://lore.kernel.org/20250509010104.669669-1-dan.j.williams@intel.com
next prev parent reply other threads:[~2025-05-13 17:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 15:47 [PATCH] tsm-mr: Fix init breakage after bin_attrs constification by scoping non-const pointers to init phase Cedric Xing
2025-05-13 16:24 ` Thomas Weißschuh
2025-05-13 16:41 ` [PATCH v2] " Cedric Xing
2025-05-13 16:49 ` Thomas Weißschuh
2025-05-13 17:27 ` dan.j.williams [this message]
2025-05-13 17:29 ` dan.j.williams
2025-05-13 18:25 ` Thomas Weißschuh
2025-05-13 18:37 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=682381198ad46_49706100fe@dwillia2-mobl4.notmuch \
--to=dan.j.williams@intel$(echo .)com \
--cc=aik@amd$(echo .)com \
--cc=cedric.xing@intel$(echo .)com \
--cc=greg@kroah$(echo .)com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux@weissschuh$(echo .)net \
--cc=lukas@wunner$(echo .)de \
--cc=sameo@rivosinc$(echo .)com \
--cc=sathyanarayanan.kuppuswamy@linux$(echo .)intel.com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=steven.price@arm$(echo .)com \
--cc=suzuki.poulose@arm$(echo .)com \
--cc=yilun.xu@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox