From: Joe Perches <joe@perches•com>
To: Bixuan Cui <cuibixuan@huawei•com>,
davem@davemloft•net, kuba@kernel•org, linux-next@vger•kernel.org
Cc: linux-kernel@vger•kernel.org, netdev@vger•kernel.org,
jdmason@kudzu•us, christophe.jaillet@wanadoo•fr,
john.wanghui@huawei•com
Subject: Re: [PATCH] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH_TX
Date: Thu, 16 Jul 2020 02:46:54 -0700 [thread overview]
Message-ID: <687734b1623965b154752252968adeca35740c88.camel@perches.com> (raw)
In-Reply-To: <20200716173247.78912-1-cuibixuan@huawei.com>
On Thu, 2020-07-16 at 17:32 +0000, Bixuan Cui wrote:
> Fix the warning: [-Werror=-Wframe-larger-than=]
[]
> diff --git a/drivers/net/ethernet/neterion/vxge/vxge-main.c b/drivers/net/ethernet/neterion/vxge/vxge-main.c
[]
> @@ -100,8 +100,14 @@ static inline void VXGE_COMPLETE_VPATH_TX(struct vxge_fifo *fifo)
> struct sk_buff **temp;
> #define NR_SKB_COMPLETED 128
> struct sk_buff *completed[NR_SKB_COMPLETED];
> + struct sk_buff **completed;
> int more;
>
> + completed = kcalloc(NR_SKB_COMPLETED, sizeof(*completed),
> + GFP_KERNEL);
I doubt this is a good idea.
Check the callers interrupt status.
next prev parent reply other threads:[~2020-07-16 9:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 17:32 [PATCH] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH_TX Bixuan Cui
2020-07-16 9:46 ` Joe Perches [this message]
2020-07-16 9:59 ` Bixuan Cui
2020-07-16 11:20 ` kernel test robot
2020-07-16 14:11 ` kernel test robot
2020-07-19 17:05 ` Stephen Hemminger
2020-07-20 1:57 ` Bixuan Cui
2020-07-20 1:58 ` [PATCH v2] " Bixuan Cui
2020-07-21 1:38 ` David Miller
2020-07-21 12:34 ` Bixuan Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=687734b1623965b154752252968adeca35740c88.camel@perches.com \
--to=joe@perches$(echo .)com \
--cc=christophe.jaillet@wanadoo$(echo .)fr \
--cc=cuibixuan@huawei$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jdmason@kudzu$(echo .)us \
--cc=john.wanghui@huawei$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox