From: Zi Yan <ziy@nvidia•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Andrew Morton <akpm@linux-foundation•org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: Re: linux-next: build warning after merge of the mm tree
Date: Wed, 25 May 2022 06:57:53 -0400 [thread overview]
Message-ID: <6CA81704-417D-4843-940E-F901803A908C@nvidia.com> (raw)
In-Reply-To: <20220525155401.4a72ad6b@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 2639 bytes --]
On 25 May 2022, at 1:54, Stephen Rothwell wrote:
> Hi all,
>
> After merging the mm tree, today's linux-next build (sparc64 defconfig)
> produced this warning:
>
> In file included from include/linux/kernel.h:26,
> from include/linux/cpumask.h:10,
> from include/linux/smp.h:13,
> from include/linux/lockdep.h:14,
> from include/linux/spinlock.h:62,
> from include/linux/mmzone.h:8,
> from include/linux/gfp.h:6,
> from include/linux/mm.h:7,
> from mm/page_alloc.c:19:
> mm/page_alloc.c: In function 'split_free_page':
> include/linux/minmax.h:20:35: warning: comparison of distinct pointer types lacks a cast
> 20 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
> | ^~
> include/linux/minmax.h:26:18: note: in expansion of macro '__typecheck'
> 26 | (__typecheck(x, y) && __no_side_effects(x, y))
> | ^~~~~~~~~~~
> include/linux/minmax.h:36:31: note: in expansion of macro '__safe_cmp'
> 36 | __builtin_choose_expr(__safe_cmp(x, y), \
> | ^~~~~~~~~~
> include/linux/minmax.h:45:25: note: in expansion of macro '__careful_cmp'
> 45 | #define min(x, y) __careful_cmp(x, y, <)
> | ^~~~~~~~~~~~~
> mm/page_alloc.c:1138:35: note: in expansion of macro 'min'
> 1138 | free_page_order = min(pfn ? __ffs(pfn) : order, __fls(split_pfn_offset));
> | ^~~
>
> Introduced by commit
>
> 29a8af92b874 ("mm: fix a potential infinite loop in start_isolate_page_range()")
Hi Stephen,
The patch below should fix it:
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 6eec0211e0be..dbbfe4a079d3 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1123,7 +1123,9 @@ void split_free_page(struct page *free_page,
pfn < free_page_pfn + (1UL << order);) {
int mt = get_pfnblock_migratetype(pfn_to_page(pfn), pfn);
- free_page_order = min(pfn ? __ffs(pfn) : order, __fls(split_pfn_offset));
+ free_page_order = min_t(unsigned long,
+ pfn ? __ffs(pfn) : order,
+ __fls(split_pfn_offset));
__free_one_page(pfn_to_page(pfn), pfn, zone, free_page_order,
mt, FPI_NONE);
pfn += 1UL << free_page_order;
--
Best Regards,
Yan, Zi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 854 bytes --]
next prev parent reply other threads:[~2022-05-25 10:58 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 5:54 linux-next: build warning after merge of the mm tree Stephen Rothwell
2022-05-25 10:57 ` Zi Yan [this message]
2022-05-25 17:36 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2025-04-04 2:14 Stephen Rothwell
2025-04-05 6:30 ` Zhiquan Li
2025-03-28 6:46 Stephen Rothwell
2025-03-28 15:08 ` Kent Overstreet
2025-03-05 9:33 Stephen Rothwell
2025-03-05 18:28 ` SeongJae Park
2025-02-18 23:46 Stephen Rothwell
2025-02-14 9:57 Stephen Rothwell
2025-02-10 3:51 Stephen Rothwell
2025-01-09 4:27 Stephen Rothwell
2025-01-06 6:37 Stephen Rothwell
2025-01-06 18:39 ` SeongJae Park
2024-10-17 8:43 Stephen Rothwell
2024-10-17 16:53 ` Sabyrzhan Tasbolatov
2024-10-17 21:16 ` Andrew Morton
2024-09-03 5:37 Stephen Rothwell
2024-09-03 6:35 ` Sergey Senozhatsky
2024-09-02 6:30 Stephen Rothwell
2024-08-12 3:30 Stephen Rothwell
2024-08-12 4:40 ` Saurabh Singh Sengar
2024-08-12 3:24 Stephen Rothwell
2024-06-06 3:23 Stephen Rothwell
2024-06-06 5:01 ` Baolin Wang
2024-06-11 21:58 ` Andrew Morton
2024-06-12 0:47 ` Baolin Wang
2024-06-06 3:19 Stephen Rothwell
2024-06-06 3:36 ` Kefeng Wang
2024-05-07 6:26 Stephen Rothwell
2024-04-17 5:18 Stephen Rothwell
2024-04-17 15:57 ` Matthew Wilcox
2024-04-15 5:20 Stephen Rothwell
2024-04-15 5:45 ` Barry Song
2024-03-27 22:13 Stephen Rothwell
2024-03-28 1:59 ` Baoquan He
2024-03-28 4:29 ` Stephen Rothwell
2024-03-25 1:25 Stephen Rothwell
2024-03-26 2:21 ` Suren Baghdasaryan
2024-03-25 1:22 Stephen Rothwell
2024-03-25 8:56 ` David Hildenbrand
2024-03-13 4:07 Stephen Rothwell
2024-03-13 9:00 ` Uwe Kleine-König
2024-03-13 15:22 ` Masahiro Yamada
2024-03-13 21:11 ` Uwe Kleine-König
2024-01-02 5:40 Stephen Rothwell
2024-01-02 12:54 ` Kirill A. Shutemov
2023-12-04 4:54 Stephen Rothwell
2023-12-04 17:03 ` SeongJae Park
2023-11-28 2:33 Stephen Rothwell
2023-10-04 4:46 Stephen Rothwell
2023-09-25 23:27 Stephen Rothwell
2023-09-18 3:18 Stephen Rothwell
2023-09-12 5:20 Stephen Rothwell
2023-06-05 3:10 Stephen Rothwell
2023-06-05 14:57 ` Liam R. Howlett
2023-05-15 23:25 Stephen Rothwell
2023-05-08 1:19 Stephen Rothwell
2023-05-08 21:36 ` Nhat Pham
2023-03-20 3:47 Stephen Rothwell
2023-03-23 2:58 ` Stephen Rothwell
2023-03-23 19:38 ` Andrew Morton
2023-03-16 1:12 Stephen Rothwell
2023-03-01 0:36 Stephen Rothwell
2023-03-01 0:47 ` Suren Baghdasaryan
2023-03-01 2:29 ` Suren Baghdasaryan
2023-03-01 5:45 ` Stephen Rothwell
2023-01-17 3:51 Stephen Rothwell
2022-12-17 19:22 Stephen Rothwell
2022-11-10 7:36 Stephen Rothwell
2022-11-10 7:33 Stephen Rothwell
2022-11-10 16:27 ` Linus Torvalds
2022-11-10 20:20 ` Randy Dunlap
2022-11-10 20:43 ` Jonathan Corbet
2022-10-26 0:57 Stephen Rothwell
2022-10-26 1:13 ` Sergey Senozhatsky
2022-09-19 9:09 Stephen Rothwell
2022-09-19 9:30 ` Miaohe Lin
2022-07-21 9:55 Stephen Rothwell
2022-07-21 11:11 ` Zach O'Keefe
2022-07-18 10:28 Stephen Rothwell
2022-07-18 22:54 ` Andrew Morton
2022-06-22 5:54 Stephen Rothwell
2022-06-22 7:11 ` Stephen Rothwell
2022-06-22 16:39 ` Mike Kravetz
2022-06-22 18:49 ` Andrew Morton
2022-05-12 9:46 Stephen Rothwell
2022-05-12 12:23 ` Johannes Weiner
2022-05-05 21:35 Stephen Rothwell
2022-05-05 21:38 ` Stephen Rothwell
2022-05-05 22:18 ` Matthew Wilcox
2022-04-28 7:44 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6CA81704-417D-4843-940E-F901803A908C@nvidia.com \
--to=ziy@nvidia$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox