From: Qian Cai <qcai@redhat•com>
To: Marc Zyngier <maz@kernel•org>,
linux-arm-kernel@lists•infradead.org,
kvmarm@lists•cs.columbia.edu
Cc: kernel-team@android•com, Stephen Rothwell <sfr@canb•auug.org.au>,
Linux Next Mailing List <linux-next@vger•kernel.org>,
Alexandru Elisei <alexandru.elisei@arm•com>
Subject: Re: [PATCH] KVM: arm64: Don't access PMCR_EL0 when no PMU is available
Date: Mon, 04 Jan 2021 10:47:30 -0500 [thread overview]
Message-ID: <703e1b5f2db1631e8f9c55619909fe66eb069f25.camel@redhat.com> (raw)
In-Reply-To: <20201210083059.1277162-1-maz@kernel.org>
On Thu, 2020-12-10 at 08:30 +0000, Marc Zyngier wrote:
> We reset the guest's view of PMCR_EL0 unconditionally, based on
> the host's view of this register. It is however legal for an
> imnplementation not to provide any PMU, resulting in an UNDEF.
>
> The obvious fix is to skip the reset of this shadow register
> when no PMU is available, sidestepping the issue entirely.
> If no PMU is available, the guest is not able to request
> a virtual PMU anyway, so not doing nothing is the right thing
> to do!
>
> It is unlikely that this bug can hit any HW implementation
> though, as they all provide a PMU. It has been found using nested
> virt with the host KVM not implementing the PMU itself.
>
> Fixes: ab9468340d2bc ("arm64: KVM: Add access handler for PMCR register")
> Signed-off-by: Marc Zyngier <maz@kernel•org>
Reverting this commit on the top of today's linux-next fixed a qemu-kvm coredump
issue on TX2 while starting a guest.
- host kernel .config:
https://cailca.coding.net/public/linux/mm/git/files/master/arm64.config
# /usr/libexec/qemu-kvm -name ubuntu-20.04-server-cloudimg -cpu host -smp 2 -m 2g
-drive if=none,format=qcow2,file=./ubuntu-20.04-server-cloudimg.qcow2,id=hd
-device virtio-scsi -device scsi-hd,drive=hd -cdrom ./ubuntu-20.04-server-cloudimg.iso
-bios /usr/share/AAVMF/AAVMF_CODE.fd -M gic-version=host -nographic
-nic user,model=virtio,hostfwd=tcp::2222-:22
qemu-kvm: /builddir/build/BUILD/qemu-4.2.0/target/arm/helper.c:1812:
pmevcntr_rawwrite: Assertion `counter < pmu_num_counters(env)' failed.
> ---
> arch/arm64/kvm/sys_regs.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c
> index bc15246775d0..6c64d010102b 100644
> --- a/arch/arm64/kvm/sys_regs.c
> +++ b/arch/arm64/kvm/sys_regs.c
> @@ -923,6 +923,10 @@ static void reset_pmcr(struct kvm_vcpu *vcpu, const
> struct sys_reg_desc *r)
> {
> u64 pmcr, val;
>
> + /* No PMU available, PMCR_EL0 may UNDEF... */
> + if (!kvm_arm_support_pmu_v3())
> + return;
> +
> pmcr = read_sysreg(pmcr_el0);
> /*
> * Writable bits of PMCR_EL0 (ARMV8_PMU_PMCR_MASK) are reset to UNKNOWN
next parent reply other threads:[~2021-01-04 15:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201210083059.1277162-1-maz@kernel.org>
2021-01-04 15:47 ` Qian Cai [this message]
2021-01-04 16:08 ` [PATCH] KVM: arm64: Don't access PMCR_EL0 when no PMU is available Marc Zyngier
2021-01-04 16:22 ` Qian Cai
2021-01-04 16:27 ` Marc Zyngier
2021-01-04 18:20 ` Qian Cai
2021-01-04 18:26 ` Marc Zyngier
2021-01-04 18:42 ` Qian Cai
2021-01-04 19:32 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=703e1b5f2db1631e8f9c55619909fe66eb069f25.camel@redhat.com \
--to=qcai@redhat$(echo .)com \
--cc=alexandru.elisei@arm$(echo .)com \
--cc=kernel-team@android$(echo .)com \
--cc=kvmarm@lists$(echo .)cs.columbia.edu \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=maz@kernel$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox