Subject: Re: mmotm 2020-01-28-20-05 uploaded (net/mptcp/subflow.c)

From: Randy Dunlap <[email-masked]>
Date: Tue, 28 Jan 2020 20:39:03 -0800

On 1/28/20 8:06 PM, [email-masked] wrote:
> The mm-of-the-moment snapshot 2020-01-28-20-05 has been uploaded to
> 
>    http://www.ozlabs.org/~akpm/mmotm/
> 
> mmotm-readme.txt says
> 
> README for mm-of-the-moment:
> 
> http://www.ozlabs.org/~akpm/mmotm/
> 
> This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
> more than once a week.
> 

Lots of build errors when CONFIG_PROC_FS is not set/enabled:

(truncation of around 500 lines of errors & warnings:)

In file included from ../include/asm-generic/percpu.h:7:0,
                 from ../arch/x86/include/asm/percpu.h:556,
                 from ../arch/x86/include/asm/preempt.h:6,
                 from ../include/linux/preempt.h:78,
                 from ../include/linux/spinlock.h:51,
                 from ../include/linux/seqlock.h:36,
                 from ../include/linux/time.h:6,
                 from ../include/linux/stat.h:19,
                 from ../include/linux/module.h:13,
                 from ../net/mptcp/subflow.c:10:
../net/mptcp/subflow.c: In function ‘mptcp_subflow_create_socket’:
../net/mptcp/subflow.c:624:25: error: ‘struct netns_core’ has no member named ‘sock_inuse’
  this_cpu_add(*net->core.sock_inuse, 1);
                         ^
../include/linux/percpu-defs.h:219:47: note: in definition of macro ‘__verify_pcpu_ptr’
  const void __percpu *__vpp_verify = (typeof((ptr) + 0))NULL; \
                                               ^~~
../include/linux/percpu-defs.h:509:33: note: in expansion of macro ‘__pcpu_size_call’
 #define this_cpu_add(pcp, val)  __pcpu_size_call(this_cpu_add_, pcp, val)
                                 ^~~~~~~~~~~~~~~~
../net/mptcp/subflow.c:624:2: note: in expansion of macro ‘this_cpu_add’
  this_cpu_add(*net->core.sock_inuse, 1);
  ^~~~~~~~~~~~
../net/mptcp/subflow.c:624:25: error: ‘struct netns_core’ has no member named ‘sock_inuse’
  this_cpu_add(*net->core.sock_inuse, 1);
                         ^
../include/linux/percpu-defs.h:376:16: note: in definition of macro ‘__pcpu_size_call’
  switch(sizeof(variable)) {     \
                ^~~~~~~~
../net/mptcp/subflow.c:624:2: note: in expansion of macro ‘this_cpu_add’
  this_cpu_add(*net->core.sock_inuse, 1);
  ^~~~~~~~~~~~
In file included from ../arch/x86/include/asm/preempt.h:6:0,
                 from ../include/linux/preempt.h:78,
                 from ../include/linux/spinlock.h:51,
                 from ../include/linux/seqlock.h:36,
                 from ../include/linux/time.h:6,
                 from ../include/linux/stat.h:19,
                 from ../include/linux/module.h:13,
                 from ../net/mptcp/subflow.c:10:
../net/mptcp/subflow.c:624:25: error: ‘struct netns_core’ has no member named ‘sock_inuse’
  this_cpu_add(*net->core.sock_inuse, 1);
                         ^
../arch/x86/include/asm/percpu.h:129:17: note: in definition of macro ‘percpu_add_op’
  typedef typeof(var) pao_T__;     \
                 ^~~
../include/linux/percpu-defs.h:377:11: note: in expansion of macro ‘this_cpu_add_1’
   case 1: stem##1(variable, __VA_ARGS__);break;  \
           ^~~~
../include/linux/percpu-defs.h:509:33: note: in expansion of macro ‘__pcpu_size_call’
 #define this_cpu_add(pcp, val)  __pcpu_size_call(this_cpu_add_, pcp, val)
                                 ^~~~~~~~~~~~~~~~
../net/mptcp/subflow.c:624:2: note: in expansion of macro ‘this_cpu_add’
  this_cpu_add(*net->core.sock_inuse, 1);
  ^~~~~~~~~~~~
../net/mptcp/subflow.c:624:25: error: ‘struct netns_core’ has no member named ‘sock_inuse’
  this_cpu_add(*net->core.sock_inuse, 1);
                         ^
../arch/x86/include/asm/percpu.h:138:17: note: in definition of macro ‘percpu_add_op’
  switch (sizeof(var)) {      \
                 ^~~
../include/linux/percpu-defs.h:377:11: note: in expansion of macro ‘this_cpu_add_1’
   case 1: stem##1(variable, __VA_ARGS__);break;  \
           ^~~~
../include/linux/percpu-defs.h:509:33: note: in expansion of macro ‘__pcpu_size_call’
 #define this_cpu_add(pcp, val)  __pcpu_size_call(this_cpu_add_, pcp, val)
                                 ^~~~~~~~~~~~~~~~
../net/mptcp/subflow.c:624:2: note: in expansion of macro ‘this_cpu_add’
  this_cpu_add(*net->core.sock_inuse, 1);
  ^~~~~~~~~~~~
../net/mptcp/subflow.c:624:25: error: ‘struct netns_core’ has no member named ‘sock_inuse’
  this_cpu_add(*net->core.sock_inuse, 1);
                         ^
../arch/x86/include/asm/percpu.h:141:45: note: in definition of macro ‘percpu_add_op’
    asm qual ("incb "__percpu_arg(0) : "+m" (var)); \
                                             ^~~
../include/linux/percpu-defs.h:377:11: note: in expansion of macro ‘this_cpu_add_1’
   case 1: stem##1(variable, __VA_ARGS__);break;  \
           ^~~~
../include/linux/percpu-defs.h:509:33: note: in expansion of macro ‘__pcpu_size_call’
 #define this_cpu_add(pcp, val)  __pcpu_size_call(this_cpu_add_, pcp, val)
                                 ^~~~~~~~~~~~~~~~
../net/mptcp/subflow.c:624:2: note: in expansion of macro ‘this_cpu_add’
  this_cpu_add(*net->core.sock_inuse, 1);
  ^~~~~~~~~~~~
../net/mptcp/subflow.c:624:25: error: ‘struct netns_core’ has no member named ‘sock_inuse’
  this_cpu_add(*net->core.sock_inuse, 1);
                         ^
../arch/x86/include/asm/percpu.h:143:45: note: in definition of macro ‘percpu_add_op’
    asm qual ("decb "__percpu_arg(0) : "+m" (var)); \
                                             ^~~
../include/linux/percpu-defs.h:377:11: note: in expansion of macro ‘this_cpu_add_1’
   case 1: stem##1(variable, __VA_ARGS__);break;  \
           ^~~~
../include/linux/percpu-defs.h:509:33: note: in expansion of macro ‘__pcpu_size_call’
 #define this_cpu_add(pcp, val)  __pcpu_size_call(this_cpu_add_, pcp, val)
                                 ^~~~~~~~~~~~~~~~
../net/mptcp/subflow.c:624:2: note: in expansion of macro ‘this_cpu_add’
  this_cpu_add(*net->core.sock_inuse, 1);
  ^~~~~~~~~~~~
../net/mptcp/subflow.c:624:25: error: ‘struct netns_core’ has no member named ‘sock_inuse’
  this_cpu_add(*net->core.sock_inuse, 1);
                         ^

-- 
~Randy
Reported-by: Randy Dunlap <[email-masked]>