From: Hannes Reinecke <hare@suse•de>
To: Stephen Rothwell <sfr@canb•auug.org.au>,
James Bottomley <James.Bottomley@HansenPartnership•com>
Cc: "Martin K. Petersen" <martin.petersen@oracle•com>,
Linux-Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Johannes Thumshirn <jth@kernel•org>
Subject: Re: linux-next: build warning after merge of the scsi-mkp tree
Date: Thu, 12 Jul 2018 08:10:08 +0200 [thread overview]
Message-ID: <7526aa85-b9ad-d314-4fde-b3936457552c@suse.de> (raw)
In-Reply-To: <20180712143057.49bfcab5@canb.auug.org.au>
On 07/12/2018 06:30 AM, Stephen Rothwell wrote:
> Hi all,
>
> On Wed, 11 Jul 2018 14:17:37 +1000 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>>
>> After merging the scsi-mkp tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
>>
>> In file included from include/linux/spinlock_types.h:18:0,
>> from include/linux/spinlock.h:82,
>> from drivers/scsi/libfc/fc_rport.c:61:
>> drivers/scsi/libfc/fc_rport.c: In function 'fc_rport_recv_req':
>> include/linux/lockdep.h:347:45: warning: 'rdata' may be used uninitialized in this function [-Wmaybe-uninitialized]
>> #define lockdep_is_held(lock) lock_is_held(&(lock)->dep_map)
>> ^
>> drivers/scsi/libfc/fc_rport.c:1832:24: note: 'rdata' was declared here
>> struct fc_rport_priv *rdata;
>> ^~~~~
>>
>> Introduced by commit
>>
>> ee35624e1e4e ("scsi: libfc: Add lockdep annotations")
>>
>> It is actually complaining about function fc_rport_recv_plogi_req()
>> (presumably it is being inlined) and this looks like an actual bug :-(
>
> This warning now appears after the merge of the scsi tree.
>
I have send a new round of patches to the scsi mailing list (cf
'libfc/fcoe: disc_mutex fixes') which address this issue.
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse•de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2018-07-12 6:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 4:17 linux-next: build warning after merge of the scsi-mkp tree Stephen Rothwell
2018-07-12 4:30 ` Stephen Rothwell
2018-07-12 6:10 ` Hannes Reinecke [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-08-28 3:13 Stephen Rothwell
2023-07-24 4:04 Stephen Rothwell
2023-07-26 2:13 ` Martin K. Petersen
2023-05-23 3:38 Stephen Rothwell
2023-05-23 6:38 ` Damien Le Moal
2023-05-23 7:49 ` Damien Le Moal
2021-10-18 20:41 Stephen Rothwell
2021-11-08 0:06 ` Stephen Rothwell
2021-11-08 14:36 ` James Bottomley
2020-03-02 2:35 Stephen Rothwell
2020-03-02 14:36 ` Brian King
2020-03-06 4:52 ` Stephen Rothwell
2020-03-06 15:30 ` Brian King
2018-12-20 6:34 Stephen Rothwell
2018-10-12 5:10 Stephen Rothwell
2017-09-26 4:09 Stephen Rothwell
2017-09-27 3:27 ` Stephen Rothwell
2017-08-24 5:57 Stephen Rothwell
2017-08-24 5:59 ` Stephen Rothwell
2016-11-14 5:16 Stephen Rothwell
2016-11-14 12:31 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7526aa85-b9ad-d314-4fde-b3936457552c@suse.de \
--to=hare@suse$(echo .)de \
--cc=James.Bottomley@HansenPartnership$(echo .)com \
--cc=jth@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=martin.petersen@oracle$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox