From: Krzysztof Kozlowski <krzk@kernel•org>
To: Kent Overstreet <kent.overstreet@linux•dev>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
Linus Torvalds <torvalds@linux-foundation•org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: Re: linux-next: build failure after merge of the origin tree
Date: Mon, 30 Sep 2024 13:00:21 +0200 [thread overview]
Message-ID: <75e2514c-7647-4d3b-9c55-c6e5c615c92e@kernel.org> (raw)
In-Reply-To: <i75zg7tnd4jvelfx6qb2pc72h45kki4vfku7qwghauztgcoywe@htrp3xhyz4u2>
On 30/09/2024 12:50, Kent Overstreet wrote:
> On Mon, Sep 30, 2024 at 12:28:40PM GMT, Krzysztof Kozlowski wrote:
>> On 30/09/2024 05:38, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> After merging the origin tree, today's linux-next build (s390
>>> defconfig) failed like this:
>>>
>>> In file included from fs/bcachefs/bset.h:9, from
>>> fs/bcachefs/btree_iter.h:5, from fs/bcachefs/str_hash.h:5, from
>>> fs/bcachefs/xattr.h:5, from fs/bcachefs/acl.c:6:
>>> fs/bcachefs/bkey.h: In function 'bch2_bkey_format_add_key':
>>> fs/bcachefs/bkey.h:557:41: error: 'const struct bkey' has no
>>> member named 'bversion'; did you mean 'version'? 557 |
>>> x(BKEY_FIELD_VERSION_HI, bversion.hi)
>>> \ | ^~~~~~~~
>>
>>
>> Also reported earlier here:
>> https://lore.kernel.org/all/202409272048.MZvBm569-lkp@intel.com/
>> https://lore.kernel.org/all/202409271712.EZRpO2Z1-lkp@intel.com/
>>
>> But the true problem is here:
>>
>> commit cf49f8a8c277f9f2b78e2a56189a741a508a9820 Author: Kent
>> Overstreet <kent.overstreet@linux•dev> AuthorDate: Thu Sep 26
>> 15:49:17 2024 -0400 ^^^^^^^^^^^ Commit: Kent Overstreet
>> <kent.overstreet@linux•dev> CommitDate: Fri Sep 27 21:46:35 2024
>> -0400 ^^^^^^^^^^^ one day difference!
>>
>> Last minute commits usually won't receive wide build coverage, at
>> least not instantaneously.
>>
>> And if you go through the history, I see around 40 commits with
>> authored date ~20-26 September and committed on Sep 27. Plus
>> another ~40 authored earlier but committed on September 21, which
>> is middle of merge window.
>>
>> Why such commits for RC1 are sent at the end of merge window or
>> committed during merge window?
>
> the rename was something I did to track down a bug in the disk
> accounting rewrite:
> https://lore.kernel.org/linux-bcachefs/pvga5sgp4vejnnr5ojgiuwte6qeve4x7ld4dhdmzb625l367fq@q4td2cutlfvu/T/
I am sorry, but I do not see how cleanup-like rename is related to
tracking down a tricky bug and fixing it. Looks like fixes got
inter-mixed with such minor refactoring.
>
> I do need to get multi-arch build testing going on my CI, but right
> now I'm busy working on corner cases in the repair code...
Well, I claim it is easy, if you wait one day for the notification from
LKP - I got notification after every push, also on success, so I am sure
that my kernel (and development, but that's unrelated) builds fine on
wide configuration. And this is free as in free beer...
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-30 11:00 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 3:38 linux-next: build failure after merge of the origin tree Stephen Rothwell
2024-09-30 10:28 ` Krzysztof Kozlowski
2024-09-30 10:50 ` Kent Overstreet
2024-09-30 11:00 ` Krzysztof Kozlowski [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-28 12:43 Mark Brown
2026-05-28 13:23 ` Miguel Ojeda
2026-05-28 13:26 ` Mark Brown
2024-12-18 4:13 Stephen Rothwell
2024-12-18 8:03 ` Jürgen Groß
2023-06-30 2:59 Stephen Rothwell
2023-06-30 3:43 ` Linus Torvalds
2021-09-19 23:42 Stephen Rothwell
2021-09-14 0:08 Stephen Rothwell
2021-09-14 0:19 ` Linus Torvalds
2021-09-14 0:24 ` Linus Torvalds
2021-09-14 0:58 ` Stephen Rothwell
2021-09-14 1:29 ` Linus Torvalds
2021-09-14 1:37 ` Linus Torvalds
2021-09-14 2:03 ` Linus Torvalds
2021-09-14 2:08 ` Stephen Rothwell
2021-09-14 2:12 ` Linus Torvalds
2021-09-14 2:50 ` Michael Ellerman
2021-09-14 12:21 ` Michael Ellerman
2021-09-14 2:39 ` Stephen Rothwell
2021-09-07 23:07 Stephen Rothwell
2021-09-07 23:09 ` Stephen Rothwell
2021-09-07 23:17 ` Marco Elver
2021-09-07 23:38 ` Miguel Ojeda
2020-07-30 22:58 Stephen Rothwell
2020-07-30 23:15 ` Stephen Rothwell
2020-07-29 23:08 Stephen Rothwell
2020-07-29 23:43 ` Linus Torvalds
2020-07-30 0:09 ` Linus Torvalds
2020-07-30 2:12 ` Linus Torvalds
2020-07-30 2:30 ` Willy Tarreau
2020-07-30 3:17 ` Kees Cook
2020-07-30 3:22 ` Willy Tarreau
2020-07-30 6:14 ` Willy Tarreau
2020-07-30 9:59 ` Marc Zyngier
2020-07-30 10:09 ` Catalin Marinas
2020-07-30 15:00 ` Will Deacon
2020-07-30 17:49 ` Kees Cook
2020-07-30 18:24 ` Linus Torvalds
2020-07-30 18:47 ` Kees Cook
2020-06-04 22:37 Stephen Rothwell
2020-06-05 0:04 ` Josh Poimboeuf
2020-06-05 9:48 ` Jessica Yu
2020-04-20 10:23 Stephen Rothwell
2020-01-31 4:12 Stephen Rothwell
2020-01-31 4:17 ` Randy Dunlap
2020-01-31 9:39 ` Daniel Lezcano
2012-10-09 23:21 Stephen Rothwell
2012-10-09 23:45 ` Andrew Morton
2012-10-09 23:52 ` Yasuaki Ishimatsu
2012-10-10 3:12 ` Stephen Rothwell
2012-10-10 0:07 ` Stephen Rothwell
2012-06-04 2:57 Stephen Rothwell
2012-06-04 7:39 ` Paul Mundt
2012-01-18 23:31 Stephen Rothwell
2012-01-19 8:21 ` Jens Axboe
2012-01-19 8:23 ` Jens Axboe
2011-11-06 23:12 Stephen Rothwell
2011-11-07 1:52 ` David Miller
2011-11-07 2:47 ` Stephen Rothwell
2011-11-07 3:36 ` David Miller
2011-11-07 5:29 ` Kirsher, Jeffrey T
2011-11-07 16:46 ` Rose, Gregory V
2011-11-07 17:46 ` Rose, Gregory V
2011-07-25 1:16 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75e2514c-7647-4d3b-9c55-c6e5c615c92e@kernel.org \
--to=krzk@kernel$(echo .)org \
--cc=kent.overstreet@linux$(echo .)dev \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=torvalds@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox