From: Pierre-Louis Bossart <pierre-louis.bossart@linux•intel.com>
To: Sinan Kaya <Okaya@kernel•org>
Cc: Mark Brown <broonie@kernel•org>,
Linux Next Mailing List <linux-next@vger•kernel.org>,
ACPI Devel Mailing List <linux-acpi@vger•kernel.org>,
Liam Girdwood <liam.r.girdwood@linux•intel.com>,
Jie Yang <yang.jie@linux•intel.com>,
Jaroslav Kysela <perex@perex•cz>, Takashi Iwai <tiwai@suse•com>,
"moderated list:INTEL ASoC DRIVERS" <alsa-devel@alsa-project•org>,
open list <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit
Date: Mon, 31 Dec 2018 15:42:10 -0600 [thread overview]
Message-ID: <765ab3a1-f1f1-3b29-aabb-0f3328abd631@linux.intel.com> (raw)
In-Reply-To: <CAK9iUCNhPg21ZFxkbqquTQ5aRRh7ojsSiFP4_RJ2_MsD4t=cYw@mail.gmail.com>
On 12/31/18 2:35 PM, Sinan Kaya wrote:
> On Mon, Dec 31, 2018 at 11:29 PM Pierre-Louis Bossart
> <pierre-louis.bossart@linux•intel.com> wrote:
>>
>> On 12/31/18 1:35 PM, Sinan Kaya wrote:
>>> On Mon, Dec 31, 2018 at 10:30 PM Mark Brown <broonie@kernel•org> wrote:
>>>> On Mon, Dec 31, 2018 at 08:52:52PM +0300, Sinan Kaya wrote:
>>>>> On Mon, Dec 31, 2018 at 8:47 PM Mark Brown <broonie@kernel•org> wrote:
>>>>>> I don't have the cover letter or anything for this series, what's going
>>>>>> on with dependencies?
>>>>> Here is the executive summary:
>>>>> I have a changeset that separates ACPI from PCI on 4.21. CONFIG_ACPI
>>>>> used to select PCI. This is no longer true.
>>>>> You can build an ACPI system without any PCI devices.
>>>> So there's no dependency and I can just apply this?
>>> The plan is to apply this patchset via ACPI tree. Need an Acked-by per patch.
>> Anytime we change the Kconfig settings for audio, we get all kinds of
>> problems with randconfig and 0day/kbuild due to depend/select issues.
>> I'd like to give this a spin first, can you share a link to the entire
>> series? Thanks!
> Sure,
>
> You can find them here
>
> https://lore.kernel.org/patchwork/patch/1028330/
>
> Click related.
Something must be missing, I get compilation errors when PCI is not
defined? And I see tons of references to pci stuff in drivers/acpi.
drivers/acpi/reboot.c: In function ‘acpi_reboot’:
drivers/acpi/reboot.c:37:10: error: implicit declaration of function
‘pci_find_bus’; did you mean ‘pci_find_next_bus’?
[-Werror=implicit-function-declaration]
bus0 = pci_find_bus(0, 0);
^~~~~~~~~~~~
pci_find_next_bus
drivers/acpi/reboot.c:37:8: warning: assignment makes pointer from
integer without a cast [-Wint-conversion]
bus0 = pci_find_bus(0, 0);
^
drivers/acpi/reboot.c:45:3: error: implicit declaration of function
‘pci_bus_write_config_byte’; did you mean ‘pci_write_config_byte’?
[-Werror=implicit-function-declaration]
pci_bus_write_config_byte(bus0, devfn,
^~~~~~~~~~~~~~~~~~~~~~~~~
pci_write_config_byte
next prev parent reply other threads:[~2018-12-31 21:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181230195612.6657-1-okaya@kernel.org>
2018-12-30 19:56 ` [PATCH v4 01/11] ACPI / LPSS: Make PCI dependency explicit Sinan Kaya
2018-12-30 19:56 ` [PATCH v4 02/11] ata: pata_acpi: " Sinan Kaya
2018-12-30 19:56 ` [PATCH v4 03/11] vga-switcheroo: make " Sinan Kaya
2019-01-07 10:34 ` Daniel Vetter
2019-01-07 10:53 ` Rafael J. Wysocki
2018-12-30 19:56 ` [PATCH v4 04/11] platform/x86: intel_ips: " Sinan Kaya
2018-12-30 19:56 ` [PATCH v4 05/11] platform/x86: intel_pmc: Make " Sinan Kaya
2018-12-30 19:56 ` [PATCH v4 06/11] platform/x86: apple-gmux: " Sinan Kaya
2018-12-30 20:01 ` Lukas Wunner
2018-12-30 19:56 ` [PATCH v4 07/11] drivers: thermal: int3406_thermal: " Sinan Kaya
2018-12-30 19:56 ` [PATCH v4 08/11] ASoC: Intel: atom: " Sinan Kaya
2018-12-31 17:46 ` Mark Brown
2018-12-31 17:52 ` Sinan Kaya
2018-12-31 19:30 ` Mark Brown
2018-12-31 19:35 ` Sinan Kaya
2018-12-31 20:29 ` Pierre-Louis Bossart
2018-12-31 20:35 ` Sinan Kaya
2018-12-31 21:42 ` Pierre-Louis Bossart [this message]
2019-01-01 1:07 ` Sinan Kaya
2019-01-02 16:34 ` [alsa-devel] " Pierre-Louis Bossart
2019-01-02 9:34 ` Rafael J. Wysocki
2019-01-02 9:36 ` Rafael J. Wysocki
2018-12-30 19:56 ` [PATCH v4 09/11] mmc: sdhci-acpi: " Sinan Kaya
2018-12-30 19:56 ` [PATCH v4 10/11] x86/intel/lpss: " Sinan Kaya
2018-12-30 19:56 ` [PATCH v4 11/11] drivers: thermal: int340x_thermal: " Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=765ab3a1-f1f1-3b29-aabb-0f3328abd631@linux.intel.com \
--to=pierre-louis.bossart@linux$(echo .)intel.com \
--cc=Okaya@kernel$(echo .)org \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=liam.r.girdwood@linux$(echo .)intel.com \
--cc=linux-acpi@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=perex@perex$(echo .)cz \
--cc=tiwai@suse$(echo .)com \
--cc=yang.jie@linux$(echo .)intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox