public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Michael Neuling <mikey@neuling•org>
To: Kyle Moffett <Kyle.D.Moffett@boeing•com>,
	Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: linuxppc-dev <linuxppc-dev@lists•ozlabs.org>,
	Paul Mackerras <paulus@samba•org>,
	Michael Ellerman <michaele@au1•ibm.com>,
	sfr@canb•auug.org.au, linux-next@vger•kernel.org
Subject: [PATCH] powerpc: fix compile error with 85xx/p1023_rds.c
Date: Thu, 08 Dec 2011 17:10:54 +1100	[thread overview]
Message-ID: <7679.1323324654@neuling.org> (raw)

Current linux-next compiled with mpc85xx_smp_defconfig causes this:
arch/powerpc/platforms/85xx/p1023_rds.c: In function 'mpc85xx_rds_pic_init':
arch/powerpc/platforms/85xx/p1023_rds.c:102:14: error: 'np' undeclared (first use in this function)
arch/powerpc/platforms/85xx/p1023_rds.c:102:14: note: each undeclared identifier is reported only once for each function it appears in

Introduced in: 
  commit 996983b75cebb1bc1c2c545f20336f24ebfa17af
  Author: Kyle Moffett <Kyle.D.Moffett@boeing•com>
  Date:   Fri Dec 2 06:28:02 2011 +0000
  powerpc/mpic: Search for open-pic device-tree node if NULL

Signed-off-by: Michael Neuling <mikey@neuling•org>

diff --git a/arch/powerpc/platforms/85xx/p1023_rds.c b/arch/powerpc/platforms/85xx/p1023_rds.c
index e92a714..d951e70 100644
--- a/arch/powerpc/platforms/85xx/p1023_rds.c
+++ b/arch/powerpc/platforms/85xx/p1023_rds.c
@@ -99,7 +99,6 @@ static void __init mpc85xx_rds_pic_init(void)
 		0, 256, " OpenPIC  ");
 
 	BUG_ON(mpic == NULL);
-	of_node_put(np);
 
 	mpic_init(mpic);
 }

             reply	other threads:[~2011-12-08  6:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-08  6:10 Michael Neuling [this message]
2011-12-09  1:39 ` [PATCH] powerpc: fix compile error with 85xx/p1010rdb.c Tony Breeds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7679.1323324654@neuling.org \
    --to=mikey@neuling$(echo .)org \
    --cc=Kyle.D.Moffett@boeing$(echo .)com \
    --cc=benh@kernel$(echo .)crashing.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=linuxppc-dev@lists$(echo .)ozlabs.org \
    --cc=michaele@au1$(echo .)ibm.com \
    --cc=paulus@samba$(echo .)org \
    --cc=sfr@canb$(echo .)auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox