public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Haojian Zhuang <haojian.zhuang@gmail•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Liam Girdwood <lrg@slimlogic•co.uk>,
	linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
	Samuel Ortiz <sameo@openedhand•com>
Subject: Re: linux-next: voltage tree build failure
Date: Sun, 11 Oct 2009 22:50:54 -0400	[thread overview]
Message-ID: <771cded00910111950y6104fe0fl4f1d10144d938243@mail.gmail.com> (raw)
In-Reply-To: <20091012132628.2f709e40.sfr@canb.auug.org.au>

On Sun, Oct 11, 2009 at 10:26 PM, Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> Hi Liam,
>
> Today's linux-next build (x86_64 allmodconfig) failed like this:
>
> drivers/built-in.o: In function `pm8607_write_device':
> 88pm8607.c:(.text+0xd1359): undefined reference to `i2c_master_send'
> drivers/built-in.o: In function `pm8607_read_device':
> 88pm8607.c:(.text+0xd13ab): undefined reference to `i2c_master_send'
> 88pm8607.c:(.text+0xd13cc): undefined reference to `i2c_master_recv'
> drivers/built-in.o: In function `pm8607_init':
> 88pm8607.c:(.init.text+0xaa22): undefined reference to `i2c_register_driver'
> drivers/built-in.o: In function `pm8607_probe':
> 88pm8607.c:(.devinit.text+0x50fb): undefined reference to `mfd_add_devices'
> drivers/built-in.o: In function `pm8607_exit':
> 88pm8607.c:(.exit.text+0x5de): undefined reference to `i2c_del_driver'
> drivers/built-in.o: In function `pm8607_remove':
> 88pm8607.c:(.devexit.text+0x1cc): undefined reference to `mfd_remove_devices'
>
> Caused by commit 258e3427f83a573d738344c2f5499da5e026e1df ("regulator:
> add 88PM8607 PMIC driver").  This is the same driver that has caused the
> mfd tree to fail in the same way since next-20091006.  I have used the
> version of the voltage tree from next-20091009 for today.
>
> --
> Cheers,
> Stephen Rothwell                    sfr@canb•auug.org.au
> http://www.canb.auug.org.au/~sfr/
>

Hi Samuel & Liam,

Please help review and merge this fix patch. I'm sorry for inconvience.

Stephen,

Thanks for your check.

From b7d3707263598c4c6671ac592eaaf13535a7b96a Mon Sep 17 00:00:00 2001
From: Haojian Zhuang <haojian.zhuang@marvell•com>
Date: Tue, 6 Oct 2009 08:08:37 -0400
Subject: [PATCH] mfd: fix the dependancy issue on 88PM8607

88PM8607 depends on I2C and MFD_CORE. Since 88PM8607 is built-in
kernel, it also requires that I2C and MFD_CORE are built-in
kernel also.

Signed-off-by: Haojian Zhuang <haojian.zhuang@marvell•com>
---
 drivers/mfd/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index fbe684b..00064e2 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -307,7 +307,7 @@ config EZX_PCAP

 config MFD_88PM8607
 	bool "Support Marvell 88PM8607"
-	depends on I2C
+	depends on I2C=y
 	select MFD_CORE
 	help
 	  This supports for Marvell 88PM8607 Power Management IC. This includes
-- 
1.5.6.5


Best Regards
Haojian

  reply	other threads:[~2009-10-12  2:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-12  2:26 linux-next: voltage tree build failure Stephen Rothwell
2009-10-12  2:50 ` Haojian Zhuang [this message]
2009-10-12 12:57   ` Mark Brown
2009-10-12 13:35     ` Samuel Ortiz
  -- strict thread matches above, loose matches on Subject: below --
2009-08-24  4:40 Stephen Rothwell
2009-04-28  6:24 Stephen Rothwell
2009-04-28 11:08 ` Liam Girdwood
2009-04-28 11:42   ` Stephen Rothwell
2009-04-30 11:06     ` Mike Rapoport
2009-01-21  2:46 Stephen Rothwell
2009-01-21 14:04 ` Jonathan Cameron
2008-07-14 13:35 Stephen Rothwell
2008-07-14 13:48 ` Liam Girdwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=771cded00910111950y6104fe0fl4f1d10144d938243@mail.gmail.com \
    --to=haojian.zhuang@gmail$(echo .)com \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=lrg@slimlogic$(echo .)co.uk \
    --cc=sameo@openedhand$(echo .)com \
    --cc=sfr@canb$(echo .)auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox