public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed

From: Thomas Zimmermann <tzimmermann@suse•de>
To: Marcel Ziswiler <marcel@ziswiler•com>,
	Linux-Next Mailing List <linux-next@vger•kernel.org>,
	dri-devel@lists•freedesktop.org,
	open list <linux-kernel@vger•kernel.org>,
	Linux ARM <linux-arm-kernel@lists•infradead.org>
Cc: Arnd Bergmann <arnd@arndb•de>,
	Alexandre Belloni <alexandre.belloni@bootlin•com>,
	David Airlie <airlied@linux•ie>,
	Maxime Ripard <mripard@kernel•org>,
	Andrey Konovalov <andreyknvl@gmail•com>,
	Stephen Rothwell <sfr@canb•auug.org.au>,
	Maarten Lankhorst <maarten.lankhorst@linux•intel.com>,
	Linus Walleij <linus.walleij@linaro•org>,
	Daniel Vetter <daniel@ffwll•ch>,
	Marcel Ziswiler <marcel.ziswiler@toradex•com>,
	Linux Kernel Functional Testing <lkft@linaro•org>
Subject: Re: [PATCH v1] drm: import DMA_BUF module namespace
Date: Wed, 27 Oct 2021 20:30:34 +0200	[thread overview]
Message-ID: <77d1966e-3081-10d3-d7a8-c159b62004aa@suse.de> (raw)
In-Reply-To: <20211027152534.3366799-1-marcel@ziswiler.com>


[-- Attachment #1.1: Type: text/plain, Size: 1725 bytes --]

Hi,

thanks for the patch.

Am 27.10.21 um 17:25 schrieb Marcel Ziswiler:
> From: Marcel Ziswiler <marcel.ziswiler@toradex•com>
> 
> Today's -next fails building arm64 defconfig as follows:
> 
> ERROR: modpost: module drm_cma_helper uses symbol dma_buf_vunmap from
>   namespace DMA_BUF, but does not import it.
> ERROR: modpost: module drm_cma_helper uses symbol dma_buf_vmap from
>   namespace DMA_BUF, but does not import it.
> 
> Reported-by: Linux Kernel Functional Testing <lkft@linaro•org>
> Fixes: commit 4b2b5e142ff4 ("drm: Move GEM memory managers into modules")
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex•com>
> 
> ---
> 
>   drivers/gpu/drm/drm_gem_cma_helper.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
> index 6f7b3f8ec04d3..69f8564ad11cd 100644
> --- a/drivers/gpu/drm/drm_gem_cma_helper.c
> +++ b/drivers/gpu/drm/drm_gem_cma_helper.c
> @@ -23,6 +23,8 @@
>   #include <drm/drm_gem_cma_helper.h>
>   #include <drm/drm_vma_manager.h>
>   
> +MODULE_IMPORT_NS(DMA_BUF);

Could this line be moved to the bottom of the file, where the other 
MODULE statements are?

In the fixed commit 4b2b5e142ff4, there's a similar change for 
drm_gem_shmem_helper.c. It uses dma-buf_vmap as well. Does that module 
require the same fix?

Do you have any idea why I don't see these errors in my builds?

Best regards
Thomas

> +
>   /**
>    * DOC: cma helpers
>    *
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

next prev parent reply	other threads:[~2021-10-27 18:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-27 15:25 [PATCH v1] drm: import DMA_BUF module namespace Marcel Ziswiler
2021-10-27 18:30 ` Thomas Zimmermann [this message]
2021-10-27 20:54   ` Marcel Ziswiler
2021-10-28 18:45     ` Thomas Zimmermann
2021-10-29  7:19       ` Marcel Ziswiler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=77d1966e-3081-10d3-d7a8-c159b62004aa@suse.de \
    --to=tzimmermann@suse$(echo .)de \
    --cc=airlied@linux$(echo .)ie \
    --cc=alexandre.belloni@bootlin$(echo .)com \
    --cc=andreyknvl@gmail$(echo .)com \
    --cc=arnd@arndb$(echo .)de \
    --cc=daniel@ffwll$(echo .)ch \
    --cc=dri-devel@lists$(echo .)freedesktop.org \
    --cc=linus.walleij@linaro$(echo .)org \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=lkft@linaro$(echo .)org \
    --cc=maarten.lankhorst@linux$(echo .)intel.com \
    --cc=marcel.ziswiler@toradex$(echo .)com \
    --cc=marcel@ziswiler$(echo .)com \
    --cc=mripard@kernel$(echo .)org \
    --cc=sfr@canb$(echo .)auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox