From: Diana Craciun OSS <diana.craciun@oss•nxp.com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Alex Williamson <alex.williamson@redhat•com>,
Bharat Bhushan <Bharat.Bhushan@nxp•com>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: Re: linux-next: build failure after merge of the vfio tree
Date: Wed, 14 Oct 2020 16:43:45 +0300 [thread overview]
Message-ID: <7b80cbae-43e9-cb5b-ddd1-c4590fd87e18@oss.nxp.com> (raw)
In-Reply-To: <20201014091653.0ec43501@canb.auug.org.au>
Thank you. The errors indicate that, most likely, the fsl-mc-bus patches
from char-misc-next are missing at this point. I have added the vfio
patches on top of linux-next (which already contains the fsl-mc-bus
patches) and built x86_64 allmodconfig. There were no errors.
Thanks,
Diana
On 10/14/2020 1:16 AM, Stephen Rothwell wrote:
> Hi Diana,
>
> On Tue, 13 Oct 2020 18:56:07 +0300 Diana Craciun OSS <diana.craciun@oss•nxp.com> wrote:
>>
>> Hi,
>>
>> How does it fail? What's the error?
>
> Sorry about that:
>
> drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c: In function 'vfio_fsl_mc_set_irq_trigger':
> drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c:121:8: error: implicit declaration of function 'fsl_mc_populate_irq_pool' [-Werror=implicit-function-declaration]
> 121 | ret = fsl_mc_populate_irq_pool(mc_cont,
> | ^~~~~~~~~~~~~~~~~~~~~~~~
> drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c:122:4: error: 'FSL_MC_IRQ_POOL_MAX_TOTAL_IRQS' undeclared (first use in this function)
> 122 | FSL_MC_IRQ_POOL_MAX_TOTAL_IRQS);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/vfio/fsl-mc/vfio_fsl_mc.c: In function 'vfio_fsl_mc_release':
> drivers/vfio/fsl-mc/vfio_fsl_mc.c:178:9: error: implicit declaration of function 'dprc_reset_container' [-Werror=implicit-function-declaration]
> 178 | ret = dprc_reset_container(mc_cont->mc_io, 0,
> | ^~~~~~~~~~~~~~~~~~~~
> drivers/vfio/fsl-mc/vfio_fsl_mc.c:181:6: error: 'DPRC_RESET_OPTION_NON_RECURSIVE' undeclared (first use in this function)
> 181 | DPRC_RESET_OPTION_NON_RECURSIVE);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/vfio/fsl-mc/vfio_fsl_mc.c:181:6: note: each undeclared identifier is reported only once for each function it appears in
> drivers/vfio/fsl-mc/vfio_fsl_mc.c:191:3: error: implicit declaration of function 'fsl_mc_cleanup_irq_pool' [-Werror=implicit-function-declaration]
> 191 | fsl_mc_cleanup_irq_pool(mc_cont);
> | ^~~~~~~~~~~~~~~~~~~~~~~
> drivers/vfio/fsl-mc/vfio_fsl_mc.c: In function 'vfio_fsl_mc_ioctl':
> drivers/vfio/fsl-mc/vfio_fsl_mc.c:316:9: error: 'DPRC_RESET_OPTION_NON_RECURSIVE' undeclared (first use in this function)
> 316 | DPRC_RESET_OPTION_NON_RECURSIVE);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/vfio/fsl-mc/vfio_fsl_mc.c: In function 'vfio_fsl_mc_mmap_mmio':
> drivers/vfio/fsl-mc/vfio_fsl_mc.c:455:36: error: 'FSL_MC_REGION_CACHEABLE' undeclared (first use in this function)
> 455 | region_cacheable = (region.type & FSL_MC_REGION_CACHEABLE) &&
> | ^~~~~~~~~~~~~~~~~~~~~~~
> drivers/vfio/fsl-mc/vfio_fsl_mc.c:456:22: error: 'FSL_MC_REGION_SHAREABLE' undeclared (first use in this function)
> 456 | (region.type & FSL_MC_REGION_SHAREABLE);
> | ^~~~~~~~~~~~~~~~~~~~~~~
> drivers/vfio/fsl-mc/vfio_fsl_mc.c: In function 'vfio_fsl_mc_bus_notifier':
> drivers/vfio/fsl-mc/vfio_fsl_mc.c:522:9: error: 'struct fsl_mc_device' has no member named 'driver_override'
> 522 | mc_dev->driver_override = kasprintf(GFP_KERNEL, "%s",
> | ^~
> drivers/vfio/fsl-mc/vfio_fsl_mc.c:524:14: error: 'struct fsl_mc_device' has no member named 'driver_override'
> 524 | if (!mc_dev->driver_override)
> | ^~
> drivers/vfio/fsl-mc/vfio_fsl_mc.c: In function 'vfio_fsl_mc_init_device':
> drivers/vfio/fsl-mc/vfio_fsl_mc.c:561:8: error: implicit declaration of function 'dprc_setup' [-Werror=implicit-function-declaration]
> 561 | ret = dprc_setup(mc_dev);
> | ^~~~~~~~~~
> drivers/vfio/fsl-mc/vfio_fsl_mc.c:567:8: error: implicit declaration of function 'dprc_scan_container' [-Werror=implicit-function-declaration]
> 567 | ret = dprc_scan_container(mc_dev, false);
> | ^~~~~~~~~~~~~~~~~~~
> drivers/vfio/fsl-mc/vfio_fsl_mc.c:576:2: error: implicit declaration of function 'dprc_remove_devices' [-Werror=implicit-function-declaration]
> 576 | dprc_remove_devices(mc_dev, NULL, 0);
> | ^~~~~~~~~~~~~~~~~~~
> drivers/vfio/fsl-mc/vfio_fsl_mc.c:577:2: error: implicit declaration of function 'dprc_cleanup' [-Werror=implicit-function-declaration]
> 577 | dprc_cleanup(mc_dev);
> | ^~~~~~~~~~~~
>
next prev parent reply other threads:[~2020-10-14 13:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 3:07 linux-next: build failure after merge of the vfio tree Stephen Rothwell
2020-10-13 15:56 ` Diana Craciun OSS
2020-10-13 19:20 ` Alex Williamson
2020-10-15 0:59 ` Stephen Rothwell
2020-10-15 2:21 ` Alex Williamson
2020-10-13 22:16 ` Stephen Rothwell
2020-10-14 13:43 ` Diana Craciun OSS [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-02-09 2:07 Mark Brown
2026-02-09 2:42 ` Mark Brown
2026-02-09 9:46 ` Edward Srouji
2026-02-09 6:30 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b80cbae-43e9-cb5b-ddd1-c4590fd87e18@oss.nxp.com \
--to=diana.craciun@oss$(echo .)nxp.com \
--cc=Bharat.Bhushan@nxp$(echo .)com \
--cc=alex.williamson@redhat$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox