From: Inaky Perez-Gonzalez <inaky@linux•intel.com>
To: netdev@vger•kernel.org
Cc: Randy Dunlap <randy.dunlap@oracle•com>,
Stephen Rothwell <sfr@canb•auug.org.au>,
wimax@linuxwimax•org, greg@kroah•com,
LKML <linux-kernel@vger•kernel.org>,
linux-wimax@intel•com, linux-next@vger•kernel.org
Subject: [PATCH 1/3] wimax: fix '#ifndef CONFIG_BUG' layout to avoid warning
Date: Wed, 7 Jan 2009 09:18:45 -0800 [thread overview]
Message-ID: <7e92a3e498e02567876f901eba29c59c294a417b.1231348339.git.inaky@linux.intel.com> (raw)
In-Reply-To: <cover.1231348339.git.inaky@linux.intel.com>
Reported by Randy Dunlap:
> Also, this warning needs to be fixed:
>
> linux-next-20090106/net/wimax/id-table.c:133: warning: ISO C90
> forbids mixed declarations and code
Move the return on #defined(CONFIG_BUG) below the variable
declarations so it doesn't violate ISO C90.
On wimax_id_table_release() we want to do a debug check if CONFIG_BUG
is enabled. However, we also want the debug code to be always compiled
to ensure there is no bitrot. It will be optimized out by the compiler
when CONFIG_BUG is disabled.
Added a note to the function header stating this.
Signed-off-by: Inaky Perez-Gonzalez <inaky@linux•intel.com>
---
net/wimax/id-table.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/net/wimax/id-table.c b/net/wimax/id-table.c
index d3b8855..5e685f7 100644
--- a/net/wimax/id-table.c
+++ b/net/wimax/id-table.c
@@ -123,15 +123,17 @@ void wimax_id_table_rm(struct wimax_dev *wimax_dev)
/*
* Release the gennetlink family id / mapping table
*
- * On debug, verify that the table is empty upon removal.
+ * On debug, verify that the table is empty upon removal. We want the
+ * code always compiled, to ensure it doesn't bit rot. It will be
+ * compiled out if CONFIG_BUG is disabled.
*/
void wimax_id_table_release(void)
{
+ struct wimax_dev *wimax_dev;
+
#ifndef CONFIG_BUG
return;
#endif
- struct wimax_dev *wimax_dev;
-
spin_lock(&wimax_id_table_lock);
list_for_each_entry(wimax_dev, &wimax_id_table, id_table_node) {
printk(KERN_ERR "BUG: %s wimax_dev %p ifindex %d not cleared\n",
--
1.5.6.5
next prev parent reply other threads:[~2009-01-07 17:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-07 17:18 [PATCH 0/3] wimax: Kbuild / rfkill-build fixes (v2) Inaky Perez-Gonzalez
2009-01-07 17:18 ` Inaky Perez-Gonzalez [this message]
2009-01-07 17:18 ` [PATCH 2/3] wimax: fix kconfig interactions with rfkill and input layers Inaky Perez-Gonzalez
2009-01-07 17:18 ` [PATCH 3/3] wimax: testing for rfkill support should also test for CONFIG_RFKILL_MODULE Inaky Perez-Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e92a3e498e02567876f901eba29c59c294a417b.1231348339.git.inaky@linux.intel.com \
--to=inaky@linux$(echo .)intel.com \
--cc=greg@kroah$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-wimax@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=randy.dunlap@oracle$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=wimax@linuxwimax$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox