From: Siarhei Liakh <sliakh.lkml@gmail•com>
To: Dave Jones <davej@redhat•com>,
Siarhei Liakh <sliakh.lkml@gmail•com>,
linux-kernel@vger•kernel.org,
linux-security-module@vger•kernel.org,
linux-next@vger•kernel.org, Arjan
Subject: Re: [PATCH v6] RO/NX protection for loadable kernel modules
Date: Mon, 5 Oct 2009 07:57:59 -0400 [thread overview]
Message-ID: <817ecb6f0910050457v5db02550m62c742f679b26577@mail.gmail.com> (raw)
In-Reply-To: <817ecb6f0909220849t2142f6bdhdeb0180dedc646d2@mail.gmail.com>
On Tue, Sep 22, 2009 at 11:49 AM, Siarhei Liakh <sliakh.lkml@gmail•com> wrote:
>> Hi Siarhei,
>> I tried out this patch on 2.6.31, and got the following trace during bootup..
>>
>> ------------[ cut here ]------------
>> WARNING: at kernel/trace/ftrace.c:1003 ftrace_bug+0x198/0x27e() (Not tainted)
>> Hardware name: VGN-Z540N
> ...
>> ---[ end trace 95b33ebf87286ae6 ]---
>> ftrace faulted on writing [<ffffffffa0000193>] video_output_register+0x11/0x10a [output]
>>
>>
>> I guess ftrace is trying to NOP out something in the modules which
>> are marked read-only ?
>
> Entirely possible. I will review ftrace and make sure the patch
> accounts for this.
I've posted new version of the patch that also sets each module's text
as RW when ftrace preps the kernel for modifications: [PATCH v7] RO/NX
protection for loadable kernel modules
Let me know how that works for you.
Thank you.
next prev parent reply other threads:[~2009-10-05 11:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-11 2:50 [PATCH v6] RO/NX protection for loadable kernel modules Siarhei Liakh
2009-09-21 21:40 ` Dave Jones
2009-09-22 15:49 ` Siarhei Liakh
2009-10-05 11:57 ` Siarhei Liakh [this message]
2009-09-21 23:59 ` Rusty Russell
2009-09-22 15:50 ` Siarhei Liakh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=817ecb6f0910050457v5db02550m62c742f679b26577@mail.gmail.com \
--to=sliakh.lkml@gmail$(echo .)com \
--cc=davej@redhat$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-security-module@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox