From: "Abhishek Sagar" <sagar.abhishek@gmail•com>
To: Ingo Molnar <mingo@elte•hu>
Cc: David Miller <davem@davemloft•net>,
Alexander Beregalov <a.beregalov@gmail•com>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
linux-next@vger•kernel.org, sparclinux@vger•kernel.org,
rostedt@goodmis•org
Subject: Re: next-0630: sparc64: build failed
Date: Wed, 2 Jul 2008 09:52:59 +0530 [thread overview]
Message-ID: <863e9df20807012122u45f7d8dfmc4d11513b19aeadc@mail.gmail.com> (raw)
In-Reply-To: <20080701200344.GA4896@elte.hu>
On Wed, Jul 2, 2008 at 1:33 AM, Ingo Molnar <mingo@elte•hu> wrote:
> hm, mcount is the facility - so it makes sense to have that defined.
> Here you basically hide CONFIG_MCOUNT:
>
>> -ifeq ($(CONFIG_MCOUNT),y)
>> - KBUILD_CFLAGS += -pg
>> +ifneq ($(CONFIG_FTRACE),y)
>> +ifeq ($(CONFIG_STACK_DEBUG),y)
>> +KBUILD_CFLAGS += -pg
>> +endif
>> endif
Even with CONFIG_MCOUNT we'd have to do something like this to prevent
duplicate -pg flags (I hope there's a prettier way of writing this):
ifneq ($(CONFIG_FTRACE),y)
ifeq ($(CONFIG_MCOUNT),y)
KBUILD_CFLAGS += -pg
endif
endif
> via two conditions. I'm not sure that's a win and i found CONFIG_MCOUNT
> a logical switch - but it's David's call.
Ok, but it really doesn't allow end user to switch between anything
through any menu. It gets selected via:
config MCOUNT
bool
depends on STACK_DEBUG || FTRACE
default y
I was attempting to decouple MCOUNT and STACK_DEBUG, which
incidentally made MCOUNT useless.
--
Regards,
Abhishek Sagar
next prev parent reply other threads:[~2008-07-02 4:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 15:25 next-0630: sparc64: build failed Alexander Beregalov
2008-07-01 15:46 ` Ingo Molnar
2008-07-01 18:48 ` Abhishek Sagar
2008-07-01 20:03 ` Ingo Molnar
2008-07-02 4:22 ` Abhishek Sagar [this message]
2008-07-02 9:10 ` Alexander Beregalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=863e9df20807012122u45f7d8dfmc4d11513b19aeadc@mail.gmail.com \
--to=sagar.abhishek@gmail$(echo .)com \
--cc=a.beregalov@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mingo@elte$(echo .)hu \
--cc=rostedt@goodmis$(echo .)org \
--cc=sparclinux@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox