From: Jani Nikula <jani.nikula@linux•intel.com>
To: Sam Ravnborg <sam@ravnborg•org>, Randy Dunlap <rdunlap@infradead•org>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
dri-devel@lists•freedesktop.org, David Airlie <airlied@linux•ie>,
Thierry Reding <thierry.reding@gmail•com>,
Linux Next Mailing List <linux-next@vger•kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux•intel.com>,
Sean Paul <sean@poorly•run>,
Laurent Pinchart <laurent.pinchart@ideasonboard•com>
Subject: Re: [PATCH v1 1/1] drm/drm_panel: Fix EXPORT of drm_panel_of_backlight() one more time
Date: Wed, 18 Dec 2019 12:30:17 +0200 [thread overview]
Message-ID: <877e2uylhi.fsf@intel.com> (raw)
In-Reply-To: <20191217194058.GA30852@ravnborg.org>
On Tue, 17 Dec 2019, Sam Ravnborg <sam@ravnborg•org> wrote:
> On Tue, Dec 17, 2019 at 08:25:03AM -0800, Randy Dunlap wrote:
>> On 12/17/19 6:07 AM, Andy Shevchenko wrote:
>> > The initial commit followed by the fix didn't take into consideration the case
>> >
>> > CONFIG_DRM_PANEL=y
>> > CONFIG_BACKLIGHT_CLASS_DEVICE=m
>> > CONFIG_DRM_I915=y
>> >
>> > where symbol devm_of_find_backlight() is not reachable from DRM subsystem.
>> > Quick fix is to avoid drm_panel_of_backlight() from exporting in such case.
>> >
>> > Fixes: 907aa265fde6 ("drm/drm_panel: fix EXPORT of drm_panel_of_backlight")
>> > Reported-by: Randy Dunlap <rdunlap@infradead•org>
>> > Cc: Linus Walleij <linus.walleij@linaro•org>
>> > Cc: Sam Ravnborg <sam@ravnborg•org>
>> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard•com>
>> > Cc: Thierry Reding <thierry.reding@gmail•com>
>> > Cc: Maarten Lankhorst <maarten.lankhorst@linux•intel.com>
>> > Cc: Sean Paul <sean@poorly•run>
>> > Cc: David Airlie <airlied@linux•ie>
>> > Cc: Daniel Vetter <daniel@ffwll•ch>
>> > Cc: Maxime Ripard <mripard@kernel•org>
>> > Cc: dri-devel@lists•freedesktop.org
>> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux•intel.com>
>>
>> Yes, that fixes the build error. Thanks.
>>
>> Acked-by: Randy Dunlap <rdunlap@infradead•org> # build-tested
>
> Hi Andy - thanks for fixing this. And thanks Randy for verifying the
> fix.
> It passed my build test and is now pushed to drm-misc-next.
As I wrote in [1], this allows a configuration that builds and links,
but is silently broken. You won't get backlight support in drm panel
which would be a reasonable expectation with
CONFIG_BACKLIGHT_CLASS_DEVICE=m.
BR,
Jani.
[1] http://mid.mail-archive.com/87d0cnynst.fsf@intel.com
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2019-12-18 10:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 14:07 [PATCH v1 1/1] drm/drm_panel: Fix EXPORT of drm_panel_of_backlight() one more time Andy Shevchenko
2019-12-17 16:25 ` Randy Dunlap
2019-12-17 19:40 ` Sam Ravnborg
2019-12-18 10:30 ` Jani Nikula [this message]
2019-12-18 10:47 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877e2uylhi.fsf@intel.com \
--to=jani.nikula@linux$(echo .)intel.com \
--cc=airlied@linux$(echo .)ie \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=laurent.pinchart@ideasonboard$(echo .)com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=rdunlap@infradead$(echo .)org \
--cc=sam@ravnborg$(echo .)org \
--cc=sean@poorly$(echo .)run \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=thierry.reding@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox