From: Rusty Russell <rusty@rustcorp•com.au>
To: linuxppc-dev@lists•ozlabs.org
Cc: linux-next@vger•kernel.org,
Paul Gortmaker <paul.gortmaker@windriver•com>,
Jim Cromie <jim.cromie@gmail•com>,
Jason Baron <jbaron@redhat•com>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
Becky Bruce <beckyb@kernel•crashing.org>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>
Subject: Re: [PATCH] powerpc: fix compile fail in hugetlb cmdline parsing
Date: Tue, 08 May 2012 13:53:24 +0930 [thread overview]
Message-ID: <878vh3cncz.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1336401142-18733-1-git-send-email-paul.gortmaker@windriver.com>
On Mon, 7 May 2012 10:32:22 -0400, Paul Gortmaker <paul.gortmaker@windriver•com> wrote:
> Commit 9fb48c744ba6a4bf58b666f4e6fdac3008ea1bd4
>
> "params: add 3rd arg to option handler callback signature"
>
> added an extra arg to the function, but didn't catch all the use
> cases needing it, causing this compile fail in mpc85xx_defconfig:
>
> arch/powerpc/mm/hugetlbpage.c:316:4: error: passing argument 7 of
> 'parse_args' from incompatible pointer type [-Werror]
>
> include/linux/moduleparam.h:317:12: note: expected
> 'int (*)(char *, char *, const char *)' but argument is of type
> 'int (*)(char *, char *)'
>
> This function has no need to printk out the "doing" value, so
> just add the arg as an "unused".
>
> Cc: Rusty Russell <rusty@rustcorp•com.au>
> Cc: Jim Cromie <jim.cromie@gmail•com>
> Cc: Jason Baron <jbaron@redhat•com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
> Cc: Becky Bruce <beckyb@kernel•crashing.org>
> Cc: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver•com>
Acked-by: Rusty Russell <rusty@rustcorp•com.au>
Thanks,
Rusty.
next prev parent reply other threads:[~2012-05-08 4:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 14:32 [PATCH] powerpc: fix compile fail in hugetlb cmdline parsing Paul Gortmaker
2012-05-08 4:23 ` Rusty Russell [this message]
2012-05-09 3:04 ` Benjamin Herrenschmidt
2012-05-09 4:03 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878vh3cncz.fsf@rustcorp.com.au \
--to=rusty@rustcorp$(echo .)com.au \
--cc=beckyb@kernel$(echo .)crashing.org \
--cc=benh@kernel$(echo .)crashing.org \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=jbaron@redhat$(echo .)com \
--cc=jim.cromie@gmail$(echo .)com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paul.gortmaker@windriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox