From: Kalle Valo <kvalo@codeaurora•org>
To: Paul Gortmaker <paul.gortmaker@windriver•com>
Cc: Larry Finger <Larry.Finger@lwfinger•net>,
linux-next@vger•kernel.org, netdev@vger•kernel.org,
linux-wireless@vger•kernel.org
Subject: Re: [linux-next] rtlwifi commit contains a patch reject file
Date: Tue, 23 Apr 2019 08:41:48 +0300 [thread overview]
Message-ID: <87a7ghxopv.fsf@purkki.adurom.net> (raw)
In-Reply-To: <20190420155008.GM23044@windriver.com> (Paul Gortmaker's message of "Sat, 20 Apr 2019 11:50:09 -0400")
Paul Gortmaker <paul.gortmaker@windriver•com> writes:
> I'm kind of surprised sfr doesn't have a bot to complain when it sees
> a foo.c.rej or foo.c.orig in a commit...
>
> Paul.
> ---
>
> $ git show --stat ddab2eee794
> commit ddab2eee7949f94b8ecdc5c84ae238826142d35d
> Author: Larry Finger <Larry.Finger@lwfinger•net>
> Date: Thu Apr 4 13:29:31 2019 -0500
>
> rtlwifi: Convert the wake_match variable to local
>
> In five of the drivers, the contents of bits 29-31 of one of the RX
> descriptors is used to set bits in a variable that is used to save the
> wakeup condition for output in a debugging statement. The resulting
> variable is not used anywhere else even though it is stored in a struct
> and could be available in other routines. This variable is changed to be
> local.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger•net>
> Signed-off-by: Kalle Valo <kvalo@codeaurora•org>
>
> drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c | 15 ++++++++-------
> drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c.rej | 10 ++++++++++
Thanks for the report, the issue was fixed by this:
b5250c9c14c1 rtlwifi: rtl8188ee: Remove extraneous file
--
Kalle Valo
prev parent reply other threads:[~2019-04-23 5:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-20 15:50 [linux-next] rtlwifi commit contains a patch reject file Paul Gortmaker
2019-04-22 2:59 ` Stephen Rothwell
[not found] ` <20190422125926.15862fdd-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2019-04-23 10:15 ` Johannes Berg
2019-04-23 5:41 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7ghxopv.fsf@purkki.adurom.net \
--to=kvalo@codeaurora$(echo .)org \
--cc=Larry.Finger@lwfinger$(echo .)net \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=paul.gortmaker@windriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox