Subject: Re: linux-next: build failure after merge of the wireless-next tree

From: Kalle Valo <[email-masked]>
Date: Thu, 16 Jan 2025 21:30:45 +0200

Ping-Ke Shih <[email-masked]> writes:

> Stephen Rothwell <[email-masked]> wrote:
>
>> Hi all,
>> 
>> After merging the wireless-next tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>> 
>> drivers/net/wireless/realtek/rtw88/led.c:19:6: error: redefinition of 'rtw_led_init'
>>    19 | void rtw_led_init(struct rtw_dev *rtwdev)
>>       |      ^~~~~~~~~~~~
>> In file included from drivers/net/wireless/realtek/rtw88/led.c:7:
>> drivers/net/wireless/realtek/rtw88/led.h:15:20: note: previous definition of 'rtw_led_init' with type
>> 'void(struct rtw_dev *)'
>>    15 | static inline void rtw_led_init(struct rtw_dev *rtwdev)
>>       |                    ^~~~~~~~~~~~
>> drivers/net/wireless/realtek/rtw88/led.c:64:6: error: redefinition of 'rtw_led_deinit'
>>    64 | void rtw_led_deinit(struct rtw_dev *rtwdev)
>>       |      ^~~~~~~~~~~~~~
>> drivers/net/wireless/realtek/rtw88/led.h:19:20: note: previous definition of 'rtw_led_deinit' with type
>> 'void(struct rtw_dev *)'
>>    19 | static inline void rtw_led_deinit(struct rtw_dev *rtwdev)
>>       |                    ^~~~~~~~~~~~~~
>> 
>> Caused by commit
>> 
>>   4b6652bc6d8d ("wifi: rtw88: Add support for LED blinking")
>> 
>> I have used the wireless-next tree from next-20250115 for today.
>
> I reproduced this issue, and fixed it by a patch [1].
>
> [1] https://lore.kernel.org/linux-wireless/[email-masked]/T/#u

The v2 of that patch is now applied:

https://git.kernel.org/wireless/wireless-next/c/b4bfbc50b1b9

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches