From: Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public•gmane.org>
To: Prasun Maiti <prasunmaiti87-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>
Cc: Amitkumar Karwar
<akarwar-eYqpPyKDWXRBDgjK7y7TUQ@public•gmane.org>,
Nishant Sarmukadam
<nishants-eYqpPyKDWXRBDgjK7y7TUQ@public•gmane.org>,
Linux Wireless
<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
Linux Next <linux-next-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
Linux Kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>
Subject: Re: [PATCH] mwifiex: Reduce endian conversion for REG Host Commands
Date: Wed, 22 Jun 2016 13:51:47 +0300 [thread overview]
Message-ID: <87eg7ph4xo.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1466591125-32128-1-git-send-email-prasunmaiti87-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> (Prasun Maiti's message of "Wed, 22 Jun 2016 15:55:25 +0530")
Prasun Maiti <prasunmaiti87-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org> writes:
> For multiple REG Host Commands (e.g HostCmd_CMD_802_11_EEPROM_ACCESS,
> HostCmd_CMD_MAC_REG_ACCESS etc.) "cpu_to_leX"-converted values are
> saved to driver. So, "leX_to_cpu" conversion is required too many
> times afterwards in driver.
>
> This patch reduces the endian: conversion without saving "cpu_to_leX"
> converted values in driver. This will convert endianness in prepare
> command and command response path.
>
> Signed-off-by: Prasun Maiti <prasunmaiti87-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>
If you send a new version of the patch mark it as [PATCH v2] and always
include a change log so that people don't need to guess what has
changed:
http://kernelnewbies.org/FirstKernelPatch#head-5c81b3c517a1d0bbc24f92594cb734e155fcbbcb
So now you should send a v3 and include a changelog.
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-06-22 10:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 14:39 [PATCH] mwifiex: Reduce endian conversion for REG Host Commands Prasun Maiti
[not found] ` <1466519967-15555-1-git-send-email-prasunmaiti87-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-06-21 14:55 ` kbuild test robot
2016-06-21 14:57 ` kbuild test robot
2016-06-21 16:41 ` kbuild test robot
2016-06-22 10:25 ` Prasun Maiti
[not found] ` <1466591125-32128-1-git-send-email-prasunmaiti87-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-06-22 10:51 ` Kalle Valo [this message]
2016-06-22 12:15 ` Prasun Maiti
[not found] ` <CAEO8o4k=2vwtYfQjJb_oKGNFcOpMDD9LSsniwJi6m74wncgZgg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-06-27 11:00 ` Kalle Valo
2016-06-23 5:21 ` [PATCH v3] " Prasun Maiti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg7ph4xo.fsf@kamboji.qca.qualcomm.com \
--to=kvalo-sgv2jx0feol9jmxxk+q4oq@public$(echo .)gmane.org \
--cc=akarwar-eYqpPyKDWXRBDgjK7y7TUQ@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-next-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=nishants-eYqpPyKDWXRBDgjK7y7TUQ@public$(echo .)gmane.org \
--cc=prasunmaiti87-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox