From: Takashi Iwai <tiwai@suse•de>
To: Brahmajit Das <listout@listout•xyz>
Cc: Takashi Iwai <tiwai@suse•de>,
linux-sound@vger•kernel.org, linux-next@vger•kernel.org,
cezary.rojewski@intel•com, liam.r.girdwood@linux•intel.com,
peter.ujfalusi@linux•intel.com, yung-chuan.liao@linux•intel.com,
broonie@kernel•org
Subject: Re: [RFC PATCH] ASoC: Intel: avs: Fix reading 1 or more bytes from a region of size 0
Date: Thu, 04 Sep 2025 11:14:21 +0200 [thread overview]
Message-ID: <87jz2etw9e.wl-tiwai@suse.de> (raw)
In-Reply-To: <dfgah3p2jump6zzqmbb6gw36ierfpth2l4fkfucskoppkwmojd@bqgh4nwh72cm>
On Thu, 04 Sep 2025 10:40:58 +0200,
Brahmajit Das wrote:
>
> On 02.09.2025 10:15, Takashi Iwai wrote:
> > On Tue, 02 Sep 2025 10:08:12 +0200,
> > Brahmajit Das wrote:
> > >
> > > Building the next tree with GCC 16, results in the following error:
> > >
> > > sound/soc/intel/avs/path.c:137:38: error: ‘strcmp’ reading 1 or more bytes from a region of size 0 [-Werror=stringop-overread]
> > > 137 | return id->id == id2->id && !strcmp(id->tplg_name, id2->tplg_name);
> > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ...snip...
> > > Signed-off-by: Brahmajit Das <listout@listout•xyz>
> > > ---
> > > sound/soc/intel/avs/path.c | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/sound/soc/intel/avs/path.c b/sound/soc/intel/avs/path.c
> > > index 7aa20fcf1a33..8c3df2002b58 100644
> > > --- a/sound/soc/intel/avs/path.c
> > > +++ b/sound/soc/intel/avs/path.c
> > > @@ -134,7 +134,8 @@ static struct avs_tplg_path *avs_condpath_find_variant(struct avs_dev *adev,
> > > static bool avs_tplg_path_template_id_equal(struct avs_tplg_path_template_id *id,
> > > struct avs_tplg_path_template_id *id2)
> > > {
> > > - return id->id == id2->id && !strcmp(id->tplg_name, id2->tplg_name);
> > > + return id->id == id2->id &&
> > > + !strncmp(id->tplg_name, id2->tplg_name, strlen(id->tplg_name));
> >
> > Please use sizeof()-1 instead of strlen(), as it's a fixed size array.
> >
> > Practically seen, it's likely a false-positive from the new compiler.
> > But it's still safer to add the boundary check in the code itself.
> >
> >
> > thanks,
> >
> > Takashi
> So, I was testing again and with sizeof, I'm getting
>
> sound/soc/intel/avs/path.c:137:38: error: ‘strncmp’ specified bound 43 exceeds source size 0 [-Werror=stringop-overread]
> 137 | return id->id == id2->id && !strncmp(id->tplg_name, id2->tplg_name,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 138 | sizeof(id->tplg_name) - 1);
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> So my previous v2 is wrong, please ignore that.
> Whereas, with strlen there's no warning :( . I'm quite confused, and
> lack the GCC knowledge.
It smells more like a compiler problem.
Care to report to gcc people before scratching too much here?
thanks,
Takashi
prev parent reply other threads:[~2025-09-04 9:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 8:08 [RFC PATCH] ASoC: Intel: avs: Fix reading 1 or more bytes from a region of size 0 Brahmajit Das
2025-09-02 8:15 ` Takashi Iwai
2025-09-02 10:13 ` [RFC PATCH v2] " Brahmajit Das
2025-09-04 8:40 ` [RFC PATCH] " Brahmajit Das
2025-09-04 9:14 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jz2etw9e.wl-tiwai@suse.de \
--to=tiwai@suse$(echo .)de \
--cc=broonie@kernel$(echo .)org \
--cc=cezary.rojewski@intel$(echo .)com \
--cc=liam.r.girdwood@linux$(echo .)intel.com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-sound@vger$(echo .)kernel.org \
--cc=listout@listout$(echo .)xyz \
--cc=peter.ujfalusi@linux$(echo .)intel.com \
--cc=yung-chuan.liao@linux$(echo .)intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox