From: ebiederm@xmission•com (Eric W. Biederman)
To: Luis Chamberlain <mcgrof@kernel•org>
Cc: Xiaoming Ni <nixiaoming@huawei•com>,
Al Viro <viro@ZenIV•linux.org.uk>,
Kees Cook <keescook@chromium•org>,
Stephen Rothwell <sfr@canb•auug.org.au>,
Helge Deller <deller@gmx•de>,
Parisc List <linux-parisc@vger•kernel.org>,
yzaikin@google•com, linux-fsdevel@vger•kernel.org,
Linux Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Christoph Hellwig <hch@lst•de>
Subject: Re: linux-next: manual merge of the vfs tree with the parisc-hd tree
Date: Tue, 12 May 2020 12:40:55 -0500 [thread overview]
Message-ID: <87k11hrqzc.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <20200512172413.GC11244@42.do-not-panic.com> (Luis Chamberlain's message of "Tue, 12 May 2020 17:24:13 +0000")
Luis Chamberlain <mcgrof@kernel•org> writes:
> On Tue, May 12, 2020 at 06:52:35AM -0500, Eric W. Biederman wrote:
>> Luis Chamberlain <mcgrof@kernel•org> writes:
>>
>> > +static struct ctl_table fs_base_table[] = {
>> > + {
>> > + .procname = "fs",
>> > + .mode = 0555,
>> > + .child = fs_table,
>> > + },
>> > + { }
>> > +};
>> ^^^^^^^^^^^^^^^^^^^^^^^^ You don't need this at all.
>> > > +static int __init fs_procsys_init(void)
>> > +{
>> > + struct ctl_table_header *hdr;
>> > +
>> > + hdr = register_sysctl_table(fs_base_table);
>> ^^^^^^^^^^^^^^^^^^^^^ Please use register_sysctl instead.
>> AKA
>> hdr = register_sysctl("fs", fs_table);
>
> Ah, much cleaner thanks!
It is my hope you we can get rid of register_sysctl_table one of these
days. It was the original interface but today it is just a
compatibility wrapper.
I unfortunately ran out of steam last time before I finished converting
everything over.
Eric
next prev parent reply other threads:[~2020-05-12 17:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 1:11 linux-next: manual merge of the vfs tree with the parisc-hd tree Stephen Rothwell
2020-05-11 1:55 ` Xiaoming Ni
2020-05-12 0:33 ` Luis Chamberlain
2020-05-12 5:22 ` Kees Cook
2020-05-12 5:44 ` Luis Chamberlain
2020-05-12 11:52 ` Eric W. Biederman
2020-05-12 17:24 ` Luis Chamberlain
2020-05-12 17:40 ` Eric W. Biederman [this message]
2020-05-12 22:03 ` Luis Chamberlain
2020-05-13 4:04 ` Xiaoming Ni
2020-05-13 12:50 ` Luis Chamberlain
2020-05-14 6:05 ` Xiaoming Ni
2020-05-14 16:17 ` Xiaoming Ni
2020-05-15 16:08 ` Luis Chamberlain
2020-05-13 13:42 ` Eric W. Biederman
2020-05-13 14:14 ` Luis Chamberlain
2020-05-13 14:44 ` Eric W. Biederman
2020-05-13 15:02 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k11hrqzc.fsf@x220.int.ebiederm.org \
--to=ebiederm@xmission$(echo .)com \
--cc=deller@gmx$(echo .)de \
--cc=hch@lst$(echo .)de \
--cc=keescook@chromium$(echo .)org \
--cc=linux-fsdevel@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=mcgrof@kernel$(echo .)org \
--cc=nixiaoming@huawei$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=viro@ZenIV$(echo .)linux.org.uk \
--cc=yzaikin@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox