From: Michael Ellerman <mpe@ellerman•id.au>
To: "Qian Cai" <cai@redhat•com>, "Cédric Le Goater" <clg@kaod•org>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
Alexey Kardashevskiy <aik@ozlabs•ru>,
linux-kernel@vger•kernel.org, linux-next@vger•kernel.org,
Oliver O'Halloran <oohall@gmail•com>,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH v2] powerpc/pci: unmap legacy INTx interrupts when a PHB is removed
Date: Wed, 14 Oct 2020 10:42:45 +1100 [thread overview]
Message-ID: <87tuuxzo96.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <90922c43c670e4b55e6cf421be19146333e2ae7b.camel@redhat.com>
Qian Cai <cai@redhat•com> writes:
> On Wed, 2020-09-23 at 09:06 +0200, Cédric Le Goater wrote:
>> On 9/23/20 2:33 AM, Qian Cai wrote:
>> > On Fri, 2020-08-07 at 12:18 +0200, Cédric Le Goater wrote:
>> > > When a passthrough IO adapter is removed from a pseries machine using
>> > > hash MMU and the XIVE interrupt mode, the POWER hypervisor expects the
>> > > guest OS to clear all page table entries related to the adapter. If
>> > > some are still present, the RTAS call which isolates the PCI slot
>> > > returns error 9001 "valid outstanding translations" and the removal of
>> > > the IO adapter fails. This is because when the PHBs are scanned, Linux
>> > > maps automatically the INTx interrupts in the Linux interrupt number
>> > > space but these are never removed.
>> > >
>> > > To solve this problem, we introduce a PPC platform specific
>> > > pcibios_remove_bus() routine which clears all interrupt mappings when
>> > > the bus is removed. This also clears the associated page table entries
>> > > of the ESB pages when using XIVE.
>> > >
>> > > For this purpose, we record the logical interrupt numbers of the
>> > > mapped interrupt under the PHB structure and let pcibios_remove_bus()
>> > > do the clean up.
>> > >
>> > > Since some PCI adapters, like GPUs, use the "interrupt-map" property
>> > > to describe interrupt mappings other than the legacy INTx interrupts,
>> > > we can not restrict the size of the mapping array to PCI_NUM_INTX. The
>> > > number of interrupt mappings is computed from the "interrupt-map"
>> > > property and the mapping array is allocated accordingly.
>> > >
>> > > Cc: "Oliver O'Halloran" <oohall@gmail•com>
>> > > Cc: Alexey Kardashevskiy <aik@ozlabs•ru>
>> > > Signed-off-by: Cédric Le Goater <clg@kaod•org>
>> >
>> > Some syscall fuzzing will trigger this on POWER9 NV where the traces pointed
>> > to
>> > this patch.
>> >
>> > .config: https://gitlab.com/cailca/linux-mm/-/blob/master/powerpc.config
>>
>> OK. The patch is missing a NULL assignement after kfree() and that
>> might be the issue.
>>
>> I did try PHB removal under PowerNV, so I would like to understand
>> how we managed to remove twice the PCI bus and possibly reproduce.
>> Any chance we could grab what the syscall fuzzer (syzkaller) did ?
>
> Any update on this? Maybe Michael or Stephen could drop this for now, so our
> fuzzing could continue to find something else new?
Someone send me a revert?
cheers
next prev parent reply other threads:[~2020-10-14 9:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200807101854.844619-1-clg@kaod.org>
2020-09-23 0:33 ` [PATCH v2] powerpc/pci: unmap legacy INTx interrupts when a PHB is removed Qian Cai
2020-09-23 7:06 ` Cédric Le Goater
2020-09-24 5:11 ` Alexey Kardashevskiy
2020-09-24 10:31 ` Cédric Le Goater
2020-10-13 19:33 ` Qian Cai
2020-10-13 23:42 ` Michael Ellerman [this message]
2020-10-14 2:55 ` Alexey Kardashevskiy
2020-11-02 14:39 ` Cédric Le Goater
2020-11-03 4:40 ` Oliver O'Halloran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tuuxzo96.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=aik@ozlabs$(echo .)ru \
--cc=cai@redhat$(echo .)com \
--cc=clg@kaod$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=oohall@gmail$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox