From: Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public•gmane.org>
To: Stanislaw Gruszka <sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public•gmane.org>
Cc: Wireless <linux-wireless-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public•gmane.org>,
Linux-Next Mailing List
<linux-next-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>
Subject: Re: [PATCH] mt76x0: build driver only as module
Date: Fri, 03 Aug 2018 13:31:01 +0300 [thread overview]
Message-ID: <87va8r68t6.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20180803100939.GE10284-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> (Stanislaw Gruszka's message of "Fri, 3 Aug 2018 12:09:40 +0200")
Stanislaw Gruszka <sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public•gmane.org> writes:
> On Fri, Aug 03, 2018 at 11:28:22AM +0200, Stanislaw Gruszka wrote:
>> > But this feels like an ugly hack to me. Isn't there a better way to fix
>> > this? (I don't have time to investigate the error in detail right now.)
>>
>> Yes, rename symbols names. And I will do this, just wanted to provide
>> quick fix for the problem.
>>
>> Moreover seems the same thing should be done for mt7601u to avoid build
>> errors and perhaps with mt76 :-(
>>
>> So I'm going to rename functions.
>
> I have the patches, I'm building kernel with allyesconfig now,
> it will take a while ...
I'm now hoping to send the pull request tomorrow, so if you can submit a
proper patch some time today that would be good.
--
Kalle Valo
prev parent reply other threads:[~2018-08-03 10:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 9:14 [PATCH] mt76x0: build driver only as module Stanislaw Gruszka
2018-08-03 9:19 ` Kalle Valo
2018-08-03 9:28 ` Stanislaw Gruszka
2018-08-03 10:09 ` Stanislaw Gruszka
[not found] ` <20180803100939.GE10284-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-08-03 10:31 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87va8r68t6.fsf@kamboji.qca.qualcomm.com \
--to=kvalo-sgv2jx0feol9jmxxk+q4oq@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-next-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=sfr-3FnU+UHB4dNDw9hX6IcOSA@public$(echo .)gmane.org \
--cc=sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox