From: John Garry <john.garry@huawei•com>
To: Christoph Hellwig <hch@infradead•org>
Cc: linux-nvme <linux-nvme@lists•infradead.org>,
Stephen Rothwell <sfr@canb•auug.org.au>,
Linux Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
<iommu@lists•linux-foundation.org>,
Robin Murphy <robin.murphy@arm•com>, <chaitanya.kulkarni@wdc•com>
Subject: Re: nvme crash - Re: linux-next: Tree for Aug 13
Date: Fri, 14 Aug 2020 14:07:02 +0100 [thread overview]
Message-ID: <895b0c2f-52eb-bd72-7cbf-aa6808c018d2@huawei.com> (raw)
In-Reply-To: <20200814120824.GB1872@infradead.org>
On 14/08/2020 13:08, Christoph Hellwig wrote:
>>>> [148.455065]__sg_alloc_table_from_pages+0xec/0x238
>>>> [148.459931]sg_alloc_table_from_pages+0x18/0x28
>>>> [148.464541]iommu_dma_alloc+0x474/0x678
>>>> [148.468455]dma_alloc_attrs+0xd8/0xf0
>>>> [148.472193]nvme_alloc_queue+0x114/0x160 [nvme]
>>>> [148.476798]nvme_reset_work+0xb34/0x14b4 [nvme]
>>>> [148.481407]process_one_work+0x1e8/0x360
>>>> [148.485405]worker_thread+0x44/0x478
>>>> [148.489055]kthread+0x150/0x158
>>>> [148.492273]ret_from_fork+0x10/0x34
>>>> [148.495838] Code: f94002c3 6b01017f 540007c2 11000486 (f8645aa5)
>>>> [148.501921] ---[ end trace 89bb2b72d59bf925 ]---
>>>>
>>>> Anything to worry about? I guess not since we're in the merge window, but
>>>> mentioning just in case ...
>> I bisected, and this patch looks to fix it (note the comments below the
>> '---'):
>>
>> From 263891a760edc24b901085bf6e5fe2480808f86d Mon Sep 17 00:00:00 2001
>> From: John Garry<john.garry@huawei•com>
>> Date: Fri, 14 Aug 2020 12:45:18 +0100
>> Subject: [PATCH] nvme-pci: Use u32 for nvme_dev.q_depth
>>
>> Recently nvme_dev.q_depth was changed from int to u16 type.
>>
>> This falls over for the queue depth calculation in nvme_pci_enable(),
>> where NVME_CAP_MQES(dev->ctrl.cap) + 1 may overflow, as NVME_CAP_MQES()
>> gives a 16b number also. That happens for me, and this is the result:
> Oh, interesting. Please also switch the module option parsing to
> use kstrtou32 and param_set_uint and send this as a formal patch.
>
I'm doing it now.
BTW, as for the DMA/sg scatterlist code, it so happens in this case that
we try the dma alloc for size=0 in nvme_alloc_queue() - I know an
allocation for size=0 makes no sense, but couldn't we bit a bit more robust?
Cheers,
John
next prev parent reply other threads:[~2020-08-14 13:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 6:58 linux-next: Tree for Aug 13 Stephen Rothwell
2020-08-13 11:00 ` nvme crash - " John Garry
2020-08-13 15:50 ` Christoph Hellwig
2020-08-14 12:00 ` John Garry
2020-08-14 12:08 ` Christoph Hellwig
2020-08-14 13:07 ` John Garry [this message]
2020-08-14 13:37 ` John Garry
2020-08-13 14:41 ` linux-next: Tree for Aug 13 [drivers/staging/vc04_services/bcm2835-camera/] Randy Dunlap
2020-08-13 18:35 ` linux-next: Tree for Aug 13 (drivers/media/i2c/max9286.c) Randy Dunlap
2020-08-13 19:01 ` Kieran Bingham
2020-08-13 21:55 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=895b0c2f-52eb-bd72-7cbf-aa6808c018d2@huawei.com \
--to=john.garry@huawei$(echo .)com \
--cc=chaitanya.kulkarni@wdc$(echo .)com \
--cc=hch@infradead$(echo .)org \
--cc=iommu@lists$(echo .)linux-foundation.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-nvme@lists$(echo .)infradead.org \
--cc=robin.murphy@arm$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox