Subject: Re: linux-next: Fixes tag needs some work in the block tree

From: Jens Axboe <[email-masked]>
Date: Tue, 22 Oct 2024 19:14:15 -0600

On 10/22/24 5:31 PM, Bart Van Assche wrote:
> On 10/22/24 3:59 PM, Stephen Rothwell wrote:
>> Hi all,
>>
>> In commit
>>
>>    6fbd7e0472b7 ("blk-mq: Make blk_mq_quiesce_tagset() hold the tag list mutex less long")
>>
>> Fixes tag
>>
>>    Fixes: commit 414dd48e882c ("blk-mq: add tagset quiesce interface")
>>
>> has these problem(s):
>>
>>    - leading word 'commit' unexpected
> 
> Jens, please let me know if you want me to post a second version of that
> patch.

I fixed it up - for future reference, I recommend adding:

[core]
	abbrev = 12
[pretty]
	fixes = Fixes: %h (\"%s\")

to ~/.gitconfig and then you can just do:

axboe@m2max ~/gi/linux (for-next)> git fixes 414dd48e882c5a39e7bd01b096ee6497eb3314b0
Fixes: 414dd48e882c ("blk-mq: add tagset quiesce interface")

and get the correctly formatted line. Whenever people try and
make them up, they always get it slightly wrong.

-- 
Jens Axboe