From: "Rafael J. Wysocki" <rjw@rjwysocki•net>
To: Jani Nikula <jani.nikula@linux•intel.com>
Cc: Randy Dunlap <rdunlap@infradead•org>,
Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, "Wysocki,
Rafael J" <rafael.j.wysocki@intel•com>,
linux-kernel@vger•kernel.org,
Daniel Vetter <daniel.vetter@ffwll•ch>,
intel-gfx <intel-gfx@lists•freedesktop.org>,
dri-devel <dri-devel@lists•freedesktop.org>,
Imre Deak <imre.deak@intel•com>
Subject: Re: linux-next: Tree for Jun 19 (drm/i915)
Date: Wed, 25 Jun 2014 01:01:36 +0200 [thread overview]
Message-ID: <9626816.NOau5dZfmB@vostro.rjw.lan> (raw)
In-Reply-To: <87y4wm8reh.fsf@intel.com>
On Tuesday, June 24, 2014 02:43:02 PM Jani Nikula wrote:
> On Thu, 19 Jun 2014, Randy Dunlap <rdunlap@infradead•org> wrote:
> > On 06/18/14 23:16, Stephen Rothwell wrote:
> >> Hi all,
> >>
> >> The powerpc allyesconfig is again broken more than usual.
> >>
> >> Changes since 20140618:
> >>
> >
> > on i386:
> >
> > CONFIG_ACPI is not enabled.
> >
> > CC drivers/gpu/drm/i915/i915_drv.o
> > ../drivers/gpu/drm/i915/i915_drv.c: In function 'i915_drm_freeze':
> > ../drivers/gpu/drm/i915/i915_drv.c:547:2: error: implicit declaration of function 'acpi_target_system_state' [-Werror=implicit-function-declaration]
> > ../drivers/gpu/drm/i915/i915_drv.c:547:36: error: 'ACPI_STATE_S3' undeclared (first use in this function)
> > ../drivers/gpu/drm/i915/i915_drv.c:547:36: note: each undeclared identifier is reported only once for each function it appears in
> > CC net/dccp/qpolicy.o
> > cc1: some warnings being treated as errors
> > make[5]: *** [drivers/gpu/drm/i915/i915_drv.o] Error 1
>
> Thanks for the report, we'll fix it.
>
> Can anyone explain why include/linux/acpi_bus.h has #ifdef
> CONFIG_ACPI_SLEEP and conditional build for a dummy inline version of
> acpi_target_system_state(), *but* that does not get included or used if
> CONFIG_ACPI=n? Additionally, the combination of CONFIG_ACPI=y and
> CONFIG_ACPI_SLEEP=n does not seem to work at all.
These two things look like bugs to me. Most likely not tested thoruoughly
enough.
> So we'll really have to sprinkle #ifdef CONFIG_ACPI all over, instead of
> neatly using the dummy versions that someone has gone through the
> trouble of adding?
No, we don't have to.
Rafael
next prev parent reply other threads:[~2014-06-24 22:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 6:16 linux-next: Tree for Jun 19 Stephen Rothwell
2014-06-19 17:15 ` linux-next: Tree for Jun 19 (vhost_scsi) Randy Dunlap
2014-06-19 18:22 ` Michael S. Tsirkin
2014-06-19 17:24 ` linux-next: Tree for Jun 19 (drm/i915) Randy Dunlap
2014-06-24 11:43 ` Jani Nikula
2014-06-24 23:01 ` Rafael J. Wysocki [this message]
2014-07-07 14:54 ` Daniel Vetter
2014-07-07 20:01 ` Rafael J. Wysocki
2014-07-07 20:06 ` Daniel Vetter
2014-07-07 21:49 ` Rafael J. Wysocki
2014-07-07 23:58 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9626816.NOau5dZfmB@vostro.rjw.lan \
--to=rjw@rjwysocki$(echo .)net \
--cc=daniel.vetter@ffwll$(echo .)ch \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=imre.deak@intel$(echo .)com \
--cc=intel-gfx@lists$(echo .)freedesktop.org \
--cc=jani.nikula@linux$(echo .)intel.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=rafael.j.wysocki@intel$(echo .)com \
--cc=rdunlap@infradead$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox