From: Ilkka Koskinen <ilkka@os•amperecomputing.com>
To: Stephen Rothwell <sfr@canb•auug.org.au>, Will Deacon <will@kernel•org>
Cc: Ilkka Koskinen <ilkka@os•amperecomputing.com>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: Re: linux-next: build failure after merge of the arm-perf tree
Date: Mon, 9 Oct 2023 22:45:18 -0700 (PDT) [thread overview]
Message-ID: <98ffbcf6-a646-ac2-5785-f78644f7cbe@os.amperecomputing.com> (raw)
In-Reply-To: <20231010095601.1443903c@canb.auug.org.au>
Hi Stephen,
On Mon, 9 Oct 2023, Stephen Rothwell wrote:
> Hi all,
>
> After merging the arm-perf tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/perf/arm_cspmu/ampere_cspmu.c: In function 'ampere_cspmu_set_ev_filter':
> drivers/perf/arm_cspmu/ampere_cspmu.c:164:9: error: implicit declaration of function 'writel' [-Werror=implicit-function-declaration]
> 164 | writel(threshold, cspmu->base0 + PMAUXR0);
> | ^~~~~~
> cc1: all warnings being treated as errors
>
> Caused by commit
>
> 290a9c0e55f8 ("perf: arm_cspmu: ampere_cspmu: Add support for Ampere SoC PMU")
>
> I have used the arm-perf tree from next-20231009 for today.
Thanks for catching the bug! It doesn't seem to happen on arm64 build but
I can reproduce it on x86_64 build indeed.
Will, it seems that "#include <linux/io.h>" is missing from
ampere_cspmu.c. After that also x86_64 build goes through. How would you
like to get the bug fixed? Shall I submit a new version of the patch, and
you would replace the old patch with the new one or is it better to
create a completely new patch that only adds the missing include line?
Cheers, Ilkka
next prev parent reply other threads:[~2023-10-10 5:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 22:56 linux-next: build failure after merge of the arm-perf tree Stephen Rothwell
2023-10-10 5:45 ` Ilkka Koskinen [this message]
2023-10-10 17:50 ` Will Deacon
2023-10-10 18:14 ` Will Deacon
2023-10-10 20:20 ` Ilkka Koskinen
-- strict thread matches above, loose matches on Subject: below --
2023-12-12 23:09 Stephen Rothwell
2023-12-13 9:30 ` Will Deacon
2023-12-13 10:15 ` James Clark
2023-12-13 10:56 ` Will Deacon
2025-03-17 0:21 Stephen Rothwell
2025-03-17 15:13 ` Will Deacon
2025-03-17 21:23 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98ffbcf6-a646-ac2-5785-f78644f7cbe@os.amperecomputing.com \
--to=ilkka@os$(echo .)amperecomputing.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=will@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox