From: Zi Yan <ziy@nvidia•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Andrew Morton <akpm@linux-foundation•org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the mm tree
Date: Tue, 24 May 2022 20:36:30 -0400 [thread overview]
Message-ID: <A4F9DAB6-B407-46DA-9B43-96DE0869D6B9@nvidia.com> (raw)
In-Reply-To: <20220525102756.368f6c02@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 1135 bytes --]
On 24 May 2022, at 20:27, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 29a8af92b874 ("mm: fix a potential infinite loop in start_isolate_page_range()")
>
> Fixes tag
>
> Fixes: b2c9e2fbba ("mm: make alloc_contig_range work at pageblock granulari=
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
> This can be fixed for the future by setting core.abbrev to 12 (or
> more) or (for git v2.11 or later) just making sure it is not set
> (or set to "auto").
Got it. my git log always shows the full SHA1. I forgot 12 digits are
required.
> - Subject has leading but no trailing parentheses
> - Subject has leading but no trailing quotes
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
>
> Please do not split Fixes tags over more than one line.
I sent the patch with transferEncoding=quoted-printable, and the raw
message of that line shows:
Fixes: b2c9e2fbba ("mm: make alloc_contig_range work at pageblock granulari=
ty")
Should I not use that option for git send-email?
Please advise. Thanks.
--
Best Regards,
Yan, Zi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 854 bytes --]
next prev parent reply other threads:[~2022-05-25 0:36 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 0:27 linux-next: Fixes tag needs some work in the mm tree Stephen Rothwell
2022-05-25 0:36 ` Zi Yan [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-02-09 6:22 Stephen Rothwell
2024-07-09 22:54 Stephen Rothwell
2024-02-25 21:18 Stephen Rothwell
2024-02-04 21:29 Stephen Rothwell
2023-12-12 20:59 Stephen Rothwell
2023-12-13 1:04 ` Andrew Morton
2023-10-17 4:33 Stephen Rothwell
2023-10-10 5:47 Stephen Rothwell
2023-10-10 15:42 ` Zi Yan
2022-11-23 22:08 Stephen Rothwell
2022-11-23 23:06 ` Jann Horn
2022-11-24 0:13 ` Andrew Morton
2022-11-24 13:37 ` Jann Horn
2022-11-23 22:00 Stephen Rothwell
2022-09-18 22:21 Stephen Rothwell
2022-09-19 14:47 ` Zach O'Keefe
2022-09-19 21:04 ` Andrew Morton
2022-09-21 18:24 ` Zach O'Keefe
2022-07-26 23:23 Stephen Rothwell
2022-07-27 0:02 ` Andrew Morton
2022-06-30 3:37 Stephen Rothwell
2022-06-30 15:28 ` Liam Howlett
2022-06-30 18:16 ` Andrew Morton
2022-06-30 3:32 Stephen Rothwell
2022-06-30 15:20 ` Liam Howlett
2022-05-13 6:56 Stephen Rothwell
2022-04-27 22:42 Stephen Rothwell
2022-04-28 2:37 ` Liam Howlett
2022-04-28 3:09 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A4F9DAB6-B407-46DA-9B43-96DE0869D6B9@nvidia.com \
--to=ziy@nvidia$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox