From: Sedat Dilek <sedat.dilek@googlemail•com>
To: Jens Axboe <jaxboe@fusionio•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
"dedekind1@gmail•com" <dedekind1@gmail•com>,
"linux-next@vger•kernel.org" <linux-next@vger•kernel.org>,
LKML <linux-kernel@vger•kernel.org>
Subject: Re: linux-next: Tree for April 1 [BROKEN ubifs when CONFIG_DEBUG_SECTION_MISMATCH=y]s
Date: Mon, 4 Apr 2011 00:38:05 +0200 [thread overview]
Message-ID: <BANLkTims96d+D_HBw1j6rvUtpMf3xcJLBw@mail.gmail.com> (raw)
In-Reply-To: <4D98F66D.9040808@fusionio.com>
On Mon, Apr 4, 2011 at 12:36 AM, Jens Axboe <jaxboe@fusionio•com> wrote:
> On 2011-04-04 00:33, Sedat Dilek wrote:
>> On Mon, Apr 4, 2011 at 12:21 AM, Jens Axboe <jaxboe@fusionio•com> wrote:
>>> On 2011-04-04 00:19, Sedat Dilek wrote:
>>>> On Mon, Apr 4, 2011 at 12:16 AM, Jens Axboe <jaxboe@fusionio•com> wrote:
>>>>> On 2011-04-02 13:02, Sedat Dilek wrote:
>>>>>> On Sat, Apr 2, 2011 at 12:14 PM, Sedat Dilek <sedat.dilek@googlemail•com> wrote:
>>>>>>> On Sat, Apr 2, 2011 at 2:20 AM, Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>>>>>>>> cc'ing Jens ...
>>>>>>>>
>>>>>>>> On Fri, 1 Apr 2011 20:22:41 +0200 Sedat Dilek <sedat.dilek@googlemail•com> wrote:
>>>>>>>>>
>>>>>>>>> On Fri, Apr 1, 2011 at 7:02 PM, Artem Bityutskiy <dedekind1@gmail•com> wrote:
>>>>>>>>>> On Fri, 2011-04-01 at 18:10 +0200, Sedat Dilek wrote:
>>>>>>>>>>> On Fri, Apr 1, 2011 at 6:06 PM, Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>>>>>>>>>>>> Cc'ing Artem,
>>>>>>>>>>>>
>>>>>>>>>>>> On Fri, 1 Apr 2011 17:55:52 +0200 Sedat Dilek <sedat.dilek@googlemail•com> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>> With CONFIG_DEBUG_SECTION_MISMATCH=y set, I see in my build.log:
>>>>>>>>>>>>> ...
>>>>>>>>>>>>> MODPOST 2742 modules
>>>>>>>>>>>>> ...
>>>>>>>>>>>>> ERROR: "empty_aops" [fs/ubifs/ubifs.ko] undefined!
>>>>>>>>>>>>> make[5]: *** [__modpost] Error 1
>>>>>>>>>>>>> make[4]: *** [modules] Error 2
>>>>>>>>>>>>> make[3]: *** [sub-make] Error 2
>>>>>>>>>>>>> make[2]: *** [all] Error 2
>>>>>>>>>>>>> make[2]: Leaving directory
>>>>>>>>>>>>> `/home/sd/src/linux-2.6/linux-2.6.39-rc1/debian/build/build_i386_none_686-iniza'
>>>>>>>>>>>>>
>>>>>> [...]
>>>>>>> Just FYI:
>>>>>>> I contacted Jens last night and he refreshed his for-linus GIT branch.
>>>>>>> Adding missing include <linux/fs.h> did not fix the issue.
>>>>>>> I am trying with the attached one.
>>>>>>>
>>>>>>> - Sedat -
>>>>>>>
>>>>>>
>>>>>> I have split the single patch into two, first reflects ther build-error.
>>>>>> The second considers {inode,file}_operations have also undefined
>>>>>> functions by using "unified" empty_{iops,fops} as used in other fs/*
>>>>>> files.
>>>>>
>>>>> What are these patches against? Not for-next nor my for-linus.
>>>>>
>>>>
>>>> I tested with linux-next (next-20110401) as base and pulled-in your
>>>> for-linus GIT branch.
>>>
>>> Then perhaps there was some merge error. There's no empty_aops defined
>>> in my tree in nilfs_mapping_init(), for instance.
>>>
>>> Are you using an old for-linus?
>>>
>>
>> I dropped the idea of exporting empty_aops via include/linux/fs.h (&
>> changes in fs/inode.c) as it did not work as intended.
>> As an alternative I used empty_{aops,iops,fops} only in
>> fs/nilfs2/page.c and fs/ubifs/xattr.c where it is only needed (for
>> example for aops: static const struct address_space_operations
>> empty_aops {}; etc.)
>
> I'm asking one thing, you are replying with something else. The patches
> you sent do NOT apply to for-linus.
>
Oh, I am sorry. I checkout your tree and adapt.
- Sedat -
next prev parent reply other threads:[~2011-04-03 22:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-01 18:22 linux-next: Tree for April 1 [BROKEN ubifs when CONFIG_DEBUG_SECTION_MISMATCH=y]s Sedat Dilek
2011-04-02 0:20 ` Stephen Rothwell
2011-04-02 10:14 ` Sedat Dilek
2011-04-02 11:02 ` Sedat Dilek
2011-04-03 22:16 ` Jens Axboe
2011-04-03 22:19 ` Sedat Dilek
2011-04-03 22:21 ` Jens Axboe
2011-04-03 22:33 ` Sedat Dilek
2011-04-03 22:36 ` Jens Axboe
2011-04-03 22:38 ` Sedat Dilek [this message]
2011-04-03 22:47 ` Jens Axboe
2011-04-03 23:14 ` Sedat Dilek
2011-04-03 23:07 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTims96d+D_HBw1j6rvUtpMf3xcJLBw@mail.gmail.com \
--to=sedat.dilek@googlemail$(echo .)com \
--cc=dedekind1@gmail$(echo .)com \
--cc=jaxboe@fusionio$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sedat.dilek@gmail$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox