Subject: Re: linux-next: Tree for April 4 [BROKEN thinkpad_acpi]

From: Sedat Dilek <[email-masked]>
Date: Mon, 4 Apr 2011 16:44:27 +0200

On Mon, Apr 4, 2011 at 3:44 PM, Sedat Dilek <[email-masked]> wrote:
> On Mon, Apr 4, 2011 at 3:00 PM, Matthew Garrett <[email-masked]> wrote:
>> On Mon, Apr 04, 2011 at 05:49:29AM -0700, Joe Perches wrote:
>>
>>> It's vdbg_printk no_printk verification.
>>>
>>> #ifdef CONFIG_THINKPAD_ACPI_DEBUG
>>> #define vdbg_printk dbg_printk
>>> static const char *str_supported(int is_supported);
>>> #else
>>> #define vdbg_printk(a_dbg_level, format, arg...)      \
>>>       no_printk(format, ##arg)
>>> #endif
>>>
>>> Two ways to handle this.
>>>
>>> 1: add
>>> static inline const char *str_supported(int is_supported) { return ""; }
>>> to the #else
>>>
>>> 2: Remove no_printk verification and return it to do {} while (0)
>>>
>>> Do you have a preference?
>>
>> I don't. Henrique?
>>
>> --
>> Matthew Garrett | [email-masked]
>>
>
> I have tried with solution #2 as it partially restores old behaviour
> (patch is attached).
>
> - Sedat -
>

Please feel free to add a:

     Reported-by: Sedat Dilek <[email-masked]>

For solution #2 :

     Tested-by: Sedat Dilek <[email-masked]>

- Sedat -