From: Geert Uytterhoeven <geert@linux-m68k•org>
To: "Rafał Miłecki" <zajec5@gmail•com>
Cc: linux-wireless@vger•kernel.org, linux-next@vger•kernel.org,
Linux Kernel Development <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH -next] bcma: main.c needs to include <linux/slab.h>
Date: Mon, 27 Jun 2011 16:09:21 +0200 [thread overview]
Message-ID: <BANLkTintpOOnu-DCGkvOYPizu9ZigHfbVg@mail.gmail.com> (raw)
In-Reply-To: <BANLkTikSLx6FKvF518s99Q8eRU_WF+cn9A@mail.gmail.com>
2011/6/27 Rafał Miłecki <zajec5@gmail•com>:
> 2011/6/26 Geert Uytterhoeven <geert@linux-m68k•org>:
>> m68k allmodconfig:
>>
>> drivers/bcma/main.c: In function ‘bcma_release_core_dev’:
>> drivers/bcma/main.c:68: error: implicit declaration of function ‘kfree’
>
> We already include slab.h in:
> host_pci.c
> scan.c
> sprom.c
>
> Maybe we can just include this in bcma.h as a better solution? We
> could drop other includes then.
> Can you submit patch for this?
If bcma.h doesn't use linux/slab.h, IMHO it should not include linux/slab.h.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k•org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2011-06-27 14:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-26 8:19 [PATCH -next] bcma: main.c needs to include <linux/slab.h> Geert Uytterhoeven
2011-06-27 13:59 ` Rafał Miłecki
2011-06-27 14:09 ` Geert Uytterhoeven [this message]
2011-06-27 14:11 ` Rafał Miłecki
[not found] ` <BANLkTikSLx6FKvF518s99Q8eRU_WF+cn9A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-06-27 14:24 ` Alexey Dobriyan
[not found] ` <BANLkTinGvM79fza-=bFwcbtfFzGHAVKJag-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-06-27 14:43 ` Rafał Miłecki
2011-06-27 16:49 ` Arend van Spriel
2011-06-27 16:57 ` Johannes Berg
2011-06-27 17:22 ` Pavel Roskin
2011-06-27 14:44 ` Pavel Roskin
[not found] ` <4E089730.1080306-mXXj517/zsQ@public.gmane.org>
2011-06-27 14:49 ` Rafał Miłecki
2011-06-27 14:53 ` Geert Uytterhoeven
2011-06-27 15:00 ` Rafał Miłecki
2011-06-28 7:58 ` Rafał Miłecki
2011-06-28 9:49 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTintpOOnu-DCGkvOYPizu9ZigHfbVg@mail.gmail.com \
--to=geert@linux-m68k$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=zajec5@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox