From: Alexandre Ghiti <alexghiti@rivosinc•com>
To: Conor Dooley <conor@kernel•org>
Cc: Randy Dunlap <rdunlap@infradead•org>,
Stephen Rothwell <sfr@canb•auug.org.au>,
Linux Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
linux-riscv <linux-riscv@lists•infradead.org>,
Palmer Dabbelt <palmer@dabbelt•com>
Subject: Re: linux-next: Tree for Dec 11 (riscv32: patch.c)
Date: Thu, 14 Dec 2023 11:05:46 +0100 [thread overview]
Message-ID: <CAHVXubhN3GQ1hu7uVof2RSByVzAGCeT_-_YvNpgaDOKuZL2fBw@mail.gmail.com> (raw)
In-Reply-To: <CAHVXubga7Q6X-zW_qztS2V_Z8TBp0gm2UV_GAj2O-5nn-_yCyA@mail.gmail.com>
On Wed, Dec 13, 2023 at 2:33 PM Alexandre Ghiti <alexghiti@rivosinc•com> wrote:
>
> On Wed, Dec 13, 2023 at 1:57 PM Conor Dooley <conor@kernel•org> wrote:
> >
> > On Tue, Dec 12, 2023 at 09:01:17AM +0100, Alexandre Ghiti wrote:
> > > Hi Randy,
> > >
> > > On Mon, Dec 11, 2023 at 10:17 PM Randy Dunlap <rdunlap@infradead•org> wrote:
> > > >
> > > >
> > > >
> > > > On 12/10/23 22:25, Stephen Rothwell wrote:
> > > > > Hi all,
> > > > >
> > > > > Changes since 20231208:
> > > > >
> > > >
> > > > on riscv32:
> > > >
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L4':
> > > > patch.c:(.text+0xbe): undefined reference to `__exittext_begin'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0xc2): undefined reference to `__exittext_begin'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L12':
> > > > patch.c:(.text+0xd2): undefined reference to `__exittext_end'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0xd6): undefined reference to `__exittext_end'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L15':
> > > > patch.c:(.text+0x1ea): undefined reference to `__exittext_begin'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L7':
> > > > patch.c:(.text+0x1ee): undefined reference to `__exittext_begin'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x1fe): undefined reference to `__exittext_end'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L22':
> > > > patch.c:(.text+0x202): undefined reference to `__exittext_end'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `__patch_insn_write':
> > > > patch.c:(.text+0x410): undefined reference to `__exittext_begin'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x414): undefined reference to `__exittext_begin'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x424): undefined reference to `__exittext_end'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x428): undefined reference to `__exittext_end'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L46':
> > > > patch.c:(.text+0x53c): undefined reference to `__exittext_begin'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x540): undefined reference to `__exittext_begin'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L48':
> > > > patch.c:(.text+0x550): undefined reference to `__exittext_end'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x554): undefined reference to `__exittext_end'
> > > >
> > > >
> > > > Full randconfig file is attached.
> > >
> > > We can ignore this one as CONFIG_XIP is enabled and we agreed at LPC
> > > that I'll remove this soon.
> >
> > I don't think we can (even if people hadn't sent patches yesterday for
> > XIP) act as if XIP being removed is a foregone conclusion.
>
> Ok, the fix is easy enough for me to send it right now, so I'll fix that :)
The fix is here
https://patchwork.kernel.org/project/linux-riscv/patch/20231214091926.203439-1-alexghiti@rivosinc.com/
and I asked Palmer to replace the v1 he already had in -fixes with
this new version, hopefully it will land in rc6.
Thanks,
Alex
next prev parent reply other threads:[~2023-12-14 10:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 6:25 linux-next: Tree for Dec 11 Stephen Rothwell
2023-12-11 21:17 ` linux-next: Tree for Dec 11 (riscv32: patch.c) Randy Dunlap
2023-12-12 8:01 ` Alexandre Ghiti
2023-12-13 12:57 ` Conor Dooley
2023-12-13 13:33 ` Alexandre Ghiti
2023-12-14 10:05 ` Alexandre Ghiti [this message]
2023-12-11 21:22 ` linux-next: Tree for Dec 11 (drivers/perf/riscv_pmu_sbi.c) Randy Dunlap
2023-12-12 7:24 ` Alexandre Ghiti
2023-12-12 21:37 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHVXubhN3GQ1hu7uVof2RSByVzAGCeT_-_YvNpgaDOKuZL2fBw@mail.gmail.com \
--to=alexghiti@rivosinc$(echo .)com \
--cc=conor@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=palmer@dabbelt$(echo .)com \
--cc=rdunlap@infradead$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox