From: Marco Elver <elver@google•com>
To: John Ogness <john.ogness@linutronix•de>
Cc: Petr Mladek <pmladek@suse•com>,
Naresh Kamboju <naresh.kamboju@linaro•org>,
Linux-Next Mailing List <linux-next@vger•kernel.org>,
open list <linux-kernel@vger•kernel.org>,
lkft-triage@lists•linaro.org, linux-mm <linux-mm@kvack•org>,
Andrew Morton <akpm@linux-foundation•org>,
Alexander Potapenko <glider@google•com>,
Dmitry Vyukov <dvyukov@google•com>,
Stephen Rothwell <sfr@canb•auug.org.au>,
Anders Roxell <anders.roxell@linaro•org>,
Andrey Konovalov <andreyknvl@gmail•com>,
Andrey Ryabinin <ryabinin.a.a@gmail•com>,
Catalin Marinas <catalin.marinas@arm•com>,
Evgenii Stepanov <eugenis@google•com>,
Mark Rutland <mark.rutland@arm•com>,
Peter Collingbourne <pcc@google•com>,
Vincenzo Frascino <vincenzo.frascino@arm•com>,
Will Deacon <will@kernel•org>
Subject: Re: [next] i386: kunit: ASSERTION FAILED at mm/kfence/kfence_test.c:547
Date: Tue, 3 May 2022 09:42:49 +0200 [thread overview]
Message-ID: <CANpmjNOgT_vvCtEOT8idcZdXgLcZrEwFvsj0GFctpCnNmq4eKA@mail.gmail.com> (raw)
In-Reply-To: <87czgwmgtc.fsf@jogness.linutronix.de>
On Mon, 2 May 2022 at 11:20, John Ogness <john.ogness@linutronix•de> wrote:
>
> On 2022-05-02, Petr Mladek <pmladek@suse•com> wrote:
> >> My proposal would be to fix the tracepoint like so:
[...]
> >> This fixes the KFENCE and KCSAN tests.
> >>
> >> Unless I hear objections, I'll prepare a patch explaining why we need to
> >> fix the tracepoint.
> >
> > It makes perfect sense to me.
>
> This is the easiest place for it. However, it should be clear that in
> the context of trace_console_rcuidle(), the message is not yet visible
> to any readers. The message _will_ get committed and definitely _will_
> become visible at some point. But it is not (yet) visible at _this_
> point. Maybe that is OK for what it is being used for.
>
> If trace_console_rcuidle() must be called at the point of visibility for
> readers, it becomes more complicated.
I think that wasn't the original intent, so fixing it up to actually
happen on printk() is probably the sanest thing. I sent the patch
trying to explain:
https://lore.kernel.org/all/20220503073844.4148944-1-elver@google.com/
Thank you both for the valuable pointers!
-- Marco
> John
prev parent reply other threads:[~2022-05-03 7:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 15:20 [next] i386: kunit: ASSERTION FAILED at mm/kfence/kfence_test.c:547 Naresh Kamboju
2022-04-29 16:17 ` Marco Elver
2022-04-30 21:08 ` John Ogness
2022-05-02 7:51 ` Marco Elver
2022-05-02 8:30 ` Petr Mladek
2022-05-02 9:20 ` John Ogness
2022-05-03 7:42 ` Marco Elver [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANpmjNOgT_vvCtEOT8idcZdXgLcZrEwFvsj0GFctpCnNmq4eKA@mail.gmail.com \
--to=elver@google$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=anders.roxell@linaro$(echo .)org \
--cc=andreyknvl@gmail$(echo .)com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=dvyukov@google$(echo .)com \
--cc=eugenis@google$(echo .)com \
--cc=glider@google$(echo .)com \
--cc=john.ogness@linutronix$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=lkft-triage@lists$(echo .)linaro.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=naresh.kamboju@linaro$(echo .)org \
--cc=pcc@google$(echo .)com \
--cc=pmladek@suse$(echo .)com \
--cc=ryabinin.a.a@gmail$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=vincenzo.frascino@arm$(echo .)com \
--cc=will@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox