From: Troy Mitchell <troy.mitchell@linux•spacemit.com>
To: Randy Dunlap <rdunlap@infradead•org>,
Troy Mitchell <troy.mitchell@linux•spacemit.com>,
Stephen Rothwell <sfr@canb•auug.org.au>,
Mark Brown <broonie@kernel•org>,
Liam Girdwood <lgirdwood@gmail•com>
Cc: Jinmei Wei <weijinmei@linux•spacemit.com>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: Re: linux-next: build warning after merge of the sound-asoc tree
Date: Mon, 27 Oct 2025 10:39:43 +0800 [thread overview]
Message-ID: <CC98F1397C1BC467+aP7bb005VjZNJmS3@kernel.org> (raw)
In-Reply-To: <b436e795-188a-4b62-95f5-1b11d2d10c77@infradead.org>
On Fri, Oct 24, 2025 at 12:40:07PM -0700, Randy Dunlap wrote:
>
>
> On 10/24/25 6:27 AM, Troy Mitchell wrote:
> > On Wed, Oct 22, 2025 at 02:17:05PM +1100, Stephen Rothwell wrote:
> >> Hi all,
> >>
> >> After merging the sound-asoc tree, today's linux-next build (powercp
> >> allyesconfig) produced this warning:
> >>
> >> WARNING: unmet direct dependencies detected for DMA_CMA
> >> Depends on [n]: HAVE_DMA_CONTIGUOUS [=n] && CMA [=y]
> >> Selected by [y]:
> >> - SND_SOC_K1_I2S [=y] && SOUND [=y] && SND [=y] && SND_SOC [=y] && (COMPILE_TEST [=y] || ARCH_SPACEMIT) && HAVE_CLK [=y]
> >>
> >> Probably introduced by commit
> >>
> >> fce217449075 ("ASoC: spacemit: add i2s support for K1 SoC")
> > Sorry, I didn't realize that this email ended up in my spam folder,
> > and I just saw it today.
> >
> > I am considering directly selecting `HAVE_DMA_CONTIGUOUS`,
> > but another possibility is to make it depend on `DMA_CMA`.
> > Can anyone advise which approach would be better?
> > If there are no objections, I plan to send a patch on Monday:
> > select `HAVE_DMA_CONTIGUOUS`
>
> Hi,
>
> My read of how HAVE_DMA_CONTIGUOUS is used is that an arch or
> platform selects it to show that it has this capability.
> Drivers don't do that.
Oh yes, that's true.
>
> Possibly ARCH_SPACEMIT should select HAVE_CONTIGUOUS_DMA but that
> wouldn't help here since this is COMPILE_TEST=y, which did
> its job here.
>
> I think this driver should
> depend on DMA_CMA
> That will take care of being dependent on both CMA and
> HAVE_CONTIGUOUS_DMA.
>
> Or IF the driver can operate without DMA_CMA being enabled,
> the driver Kconfig could do
> select DMA_CMA if HAVE_DMA_CONTIGUOUS && CMA
> and then have alternate code paths for whatever is
> enabled.
>
> This driver could
> select CMA if MMU
>
> or it could do
> depends on MMU
> depends on HAVE_CONTIGUOUS_DMA
> select CMA
>
> but
> depends on DMA_CMA
> wraps all of driver dependencies into one statement.
> But no, not
> select HAVE_CONTIGUOUS_DMA
Yes, thank you for the clarification.
I will go with using depends on.
I also think I no longer need to select HAVE_DMA_CONTIGUOUS
in ARCH_SPACEMIT, as it is handled here:
arch/riscv/Kconfig +154
- Troy
>
> --
> ~Randy
>
>
next prev parent reply other threads:[~2025-10-27 2:42 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 3:17 linux-next: build warning after merge of the sound-asoc tree Stephen Rothwell
2025-10-24 13:27 ` Troy Mitchell
2025-10-24 19:40 ` Randy Dunlap
2025-10-27 2:39 ` Troy Mitchell [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-02-20 5:09 Stephen Rothwell
2024-12-16 2:09 Stephen Rothwell
2024-12-19 6:33 ` Stephen Rothwell
[not found] ` <AM0PR04MB7044110ACEF4D67F3C37AD4CE3062@AM0PR04MB7044.eurprd04.prod.outlook.com>
2024-12-19 11:13 ` Mark Brown
2024-12-19 11:23 ` Stephen Rothwell
2024-12-20 8:58 ` Takashi Iwai
2024-11-08 6:47 Stephen Rothwell
2023-12-12 0:16 Stephen Rothwell
2023-12-12 9:35 ` Charles Keepax
2023-07-13 2:16 Stephen Rothwell
2023-07-13 12:19 ` Andy Shevchenko
2023-07-13 12:41 ` Andy Shevchenko
2023-07-14 9:18 ` Andy Shevchenko
2023-07-24 3:58 ` Stephen Rothwell
2023-07-24 8:26 ` Andy Shevchenko
2023-07-24 12:36 ` Mark Brown
2023-07-24 13:05 ` Andy Shevchenko
2023-07-24 13:11 ` Mark Brown
2023-07-24 13:44 ` Andy Shevchenko
2023-07-24 15:18 ` Jonathan Corbet
2021-10-26 7:54 Stephen Rothwell
2021-08-13 2:17 Stephen Rothwell
2021-08-13 14:35 ` Doug Anderson
2021-04-19 3:41 Stephen Rothwell
2021-03-23 5:43 Stephen Rothwell
2021-03-23 6:13 ` Mukunda,Vijendar
2020-11-11 2:34 Stephen Rothwell
2020-10-02 4:14 Stephen Rothwell
2020-09-18 3:21 Stephen Rothwell
2020-09-18 9:21 ` Kai Vehmanen
2020-08-19 1:34 Stephen Rothwell
2020-05-28 3:57 Stephen Rothwell
2020-05-29 13:30 ` Mark Brown
2020-05-29 13:55 ` Pierre-Louis Bossart
2020-05-29 14:27 ` Pierre-Louis Bossart
2020-04-24 6:26 Stephen Rothwell
2020-03-03 1:29 Stephen Rothwell
2020-03-01 23:57 Stephen Rothwell
2019-10-22 23:45 Stephen Rothwell
2019-10-07 23:58 Stephen Rothwell
2019-04-26 3:05 Stephen Rothwell
2019-04-26 3:14 ` Nicolin Chen
2019-04-09 1:46 Stephen Rothwell
2019-03-25 23:01 Stephen Rothwell
2019-04-08 23:12 ` Stephen Rothwell
2019-04-09 4:04 ` Annaliese McDermond
2019-03-19 23:45 Stephen Rothwell
2019-02-21 2:13 Stephen Rothwell
[not found] <CGME20190213013212epcas5p436da6762dea86287ed3aea31ef2bb830@epcas5p4.samsung.com>
2019-02-13 1:31 ` Stephen Rothwell
2019-02-13 10:35 ` Sylwester Nawrocki
2018-09-07 0:57 Stephen Rothwell
2018-08-02 4:06 Stephen Rothwell
2018-08-02 14:37 ` Mark Brown
2018-07-26 2:19 Stephen Rothwell
2018-07-26 5:58 ` Agrawal, Akshu
2018-05-10 3:09 Stephen Rothwell
2018-02-13 1:51 Stephen Rothwell
2018-02-13 2:55 ` Kuninori Morimoto
2017-11-01 4:13 Stephen Rothwell
2017-09-04 2:27 Stephen Rothwell
2017-08-23 2:20 Stephen Rothwell
2017-08-23 6:03 ` Takashi Iwai
2017-07-03 2:26 Stephen Rothwell
2017-04-27 1:29 Stephen Rothwell
2017-04-27 2:27 ` Vinod Koul
2017-02-01 2:14 Stephen Rothwell
2016-12-06 0:11 Stephen Rothwell
2015-07-13 3:23 Stephen Rothwell
2015-07-13 6:14 ` Valentin Rothberg
2015-03-19 3:45 Stephen Rothwell
2014-04-15 1:44 Stephen Rothwell
2014-02-20 3:01 Stephen Rothwell
2012-06-08 4:03 Stephen Rothwell
2012-04-05 1:03 Stephen Rothwell
2012-04-05 14:32 ` MR Swami Reddy
2012-01-09 1:55 Stephen Rothwell
2012-01-09 3:03 ` Axel Lin
2012-01-09 3:10 ` Mark Brown
2010-12-27 23:32 Stephen Rothwell
2010-12-28 9:18 ` Peter Ujfalusi
2010-08-17 2:21 Stephen Rothwell
2010-08-17 23:30 ` Liam Girdwood
2010-08-18 8:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CC98F1397C1BC467+aP7bb005VjZNJmS3@kernel.org \
--to=troy.mitchell@linux$(echo .)spacemit.com \
--cc=broonie@kernel$(echo .)org \
--cc=lgirdwood@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=rdunlap@infradead$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=weijinmei@linux$(echo .)spacemit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox