From: Felix Blyakher <felixb@sgi•com>
To: Christoph Hellwig <hch@lst•de>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
David Chinner <david@fromorbit•com>,
xfs-masters@oss•sgi.com, linux-next@vger•kernel.org,
linux-kernel@vger•kernel.org, Alex Elder <aelder@sgi•com>
Subject: Re: linux-next: xfs tree build failure
Date: Tue, 1 Sep 2009 20:54:07 -0500 [thread overview]
Message-ID: <F0C21C0B-E90E-44DF-B094-CC5F1DA7EDCE@sgi.com> (raw)
In-Reply-To: <20090902012844.GA15549@lst.de>
On Sep 1, 2009, at 8:28 PM, Christoph Hellwig wrote:
> On Wed, Sep 02, 2009 at 11:25:09AM +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
>>
>> fs/xfs/xfs_ialloc.c:63: error: static declaration of
>> 'xfs_inobt_lookup' follows non-static declaration
>> fs/xfs/xfs_ialloc.h:155: note: previous declaration of
>> 'xfs_inobt_lookup' was here
>>
>> Caused by commit 2187550525d7bcb8c87689e4eca41b1955bf9ac3 ("xfs:
>> rationalize xfs_inobt_lookup*").
>
> I've sent a fix to the list about an hour ago:
I've reviewed it and picked it up right away.
Thanks, Christoph.
> Subject: [PATCH] xfs: un-static xfs_inobt_lookup
> From: Christoph Hellwig <hch@lst•de>
>
> xfs_inobt_lookup is also used in xfs_itable.c, remove the STATIC
> modifier
> from it's declaration to fix non-debug builds.
>
> This was already fixed in my git tree vs the version last posted to
> the
> list.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst•de>
>
> Index: xfs/fs/xfs/xfs_ialloc.c
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_ialloc.c 2009-09-01 20:47:28.515468366 -0300
> +++ xfs/fs/xfs/xfs_ialloc.c 2009-09-01 20:47:33.867913011 -0300
> @@ -59,7 +59,7 @@ xfs_ialloc_cluster_alignment(
> /*
> * Lookup a record by ino in the btree given by cur.
> */
> -STATIC int /* error */
> +int /* error */
> xfs_inobt_lookup(
> struct xfs_btree_cur *cur, /* btree cursor */
> xfs_agino_t ino, /* starting inode of chunk */
>>
>> I have used the version of the xfs tree from next-20090901 for today.
Argh! It was broken just for couple of hours.
The fix is now in official xfs tree as well.
Thanks,
Felix
>>
>> --
>> Cheers,
>> Stephen Rothwell sfr@canb•auug.org.au
>> http://www.canb.auug.org.au/~sfr/
>
>
> ---end quoted text---
next prev parent reply other threads:[~2009-09-02 1:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 1:25 linux-next: xfs tree build failure Stephen Rothwell
2009-09-02 1:28 ` Christoph Hellwig
2009-09-02 1:54 ` Felix Blyakher [this message]
2009-09-02 2:00 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2009-07-03 0:05 Stephen Rothwell
2009-03-10 2:45 Stephen Rothwell
2009-03-11 22:52 ` Dave Chinner
2009-03-12 1:04 ` Stephen Rothwell
2009-03-15 12:18 ` Dave Chinner
2008-12-03 23:16 Stephen Rothwell
2008-12-04 5:20 ` Eric Sandeen
2008-10-30 2:23 Stephen Rothwell
2008-10-30 9:08 ` Dave Chinner
2008-11-05 2:20 ` Stephen Rothwell
2008-11-05 20:47 ` Dave Chinner
2008-11-06 15:27 ` Christoph Hellwig
2008-11-07 5:06 ` Stephen Rothwell
2008-11-11 2:05 ` Lachlan McIlroy
2008-11-11 2:11 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F0C21C0B-E90E-44DF-B094-CC5F1DA7EDCE@sgi.com \
--to=felixb@sgi$(echo .)com \
--cc=aelder@sgi$(echo .)com \
--cc=david@fromorbit$(echo .)com \
--cc=hch@lst$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=xfs-masters@oss$(echo .)sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox