From: Geert Uytterhoeven <geert@linux-m68k•org>
To: Eric Sandeen <sandeen@sandeen•net>,
Christoph Hellwig <hch@lst•de>, Lachlan McIlroy <lachlan@sgi•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
xfs@oss•sgi.com, linux-next@vger•kernel.org,
LKML <linux-kernel@vger•kernel.org>
Subject: XFS breakage on m68k (was: Re: linux-next: Tree for December 3)
Date: Thu, 4 Dec 2008 10:02:15 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.0812040956370.10635@anakin> (raw)
In-Reply-To: <20081203183602.c06f8c39.sfr@canb.auug.org.au>
On Wed, 3 Dec 2008, Stephen Rothwell wrote:
> Status of my local build tests will be at
> http://kisskb.ellerman.id.au/linux-next . If maintainers want to give
> advice about cross compilers/configs that work, we are always open to add
> more builds.
On m68k (32-bit only, no compat32), XFS fails to build in linux-next:
| fs/xfs/linux-2.6/xfs_ioctl32.h:50: error: syntax error before 'compat_time_t'
| fs/xfs/linux-2.6/xfs_ioctl32.h:52: error: syntax error before '}' token
| fs/xfs/linux-2.6/xfs_ioctl32.h:63: error: syntax error before 'compat_xfs_bstime_t'
| fs/xfs/linux-2.6/xfs_ioctl32.h:65: error: syntax error before 'bs_ctime'
| fs/xfs/linux-2.6/xfs_ioctl32.h:76: error: syntax error before '}' token
| fs/xfs/linux-2.6/xfs_ioctl32.h:79: error: syntax error before 'compat_uptr_t'
| fs/xfs/linux-2.6/xfs_ioctl32.h:81: error: syntax error before 'ubuffer'
| fs/xfs/linux-2.6/xfs_ioctl32.h:82: error: syntax error before 'ocount'
| fs/xfs/linux-2.6/xfs_ioctl32.h:94: error: syntax error before 'compat_uptr_t'
| fs/xfs/linux-2.6/xfs_ioctl32.h:96: error: syntax error before 'ihandle'
| fs/xfs/linux-2.6/xfs_ioctl32.h:98: error: syntax error before 'ohandle'
| fs/xfs/linux-2.6/xfs_ioctl32.h:99: error: syntax error before 'ohandlen'
| fs/xfs/linux-2.6/xfs_ioctl32.h:121: error: syntax error before 'compat_xfs_bstat_t'
| fs/xfs/linux-2.6/xfs_ioctl32.h:127: error: field 'hreq' has incomplete type
| fs/xfs/linux-2.6/xfs_ioctl32.h:131: error: syntax error before 'compat_uptr_t'
| fs/xfs/linux-2.6/xfs_ioctl32.h:142: error: syntax error before 'compat_uptr_t'
| fs/xfs/linux-2.6/xfs_ioctl32.h:146: error: syntax error before '}' token
| fs/xfs/linux-2.6/xfs_ioctl32.h:149: error: field 'hreq' has incomplete type
| fs/xfs/linux-2.6/xfs_ioctl32.h:152: error: syntax error before 'compat_uptr_t'
| fs/xfs/linux-2.6/xfs_ioctl32.h:159: error: field 'hreq' has incomplete type
| fs/xfs/linux-2.6/xfs_ioctl32.h:161: error: syntax error before 'compat_uptr_t'
| distcc[28223] ERROR: compile fs/xfs/linux-2.6/xfs_file.c on localhost failed
(http://kisskb.ellerman.id.au/kisskb/buildresult/58941/)
or (with a different compiler):
| In file included from fs/xfs/linux-2.6/xfs_file.c:39:
| fs/xfs/linux-2.6/xfs_ioctl32.h:50: error: expected specifier-qualifier-list before 'compat_time_t'
| fs/xfs/linux-2.6/xfs_ioctl32.h:79: error: expected specifier-qualifier-list before 'compat_uptr_t'
| fs/xfs/linux-2.6/xfs_ioctl32.h:94: error: expected specifier-qualifier-list before 'compat_uptr_t'
| make[2]: *** [fs/xfs/linux-2.6/xfs_file.o] Error 1
git bisect run says:
ffae263a640b736a7206a0d7bd14ab44eb58cd28 is first bad commit
commit ffae263a640b736a7206a0d7bd14ab44eb58cd28
Author: sandeen@sandeen•net <sandeen@sandeen•net>
Date: Tue Nov 25 21:20:07 2008 -0600
[XFS] Move compat ioctl structs & numbers into xfs_ioctl32.h
This makes the c file less cluttered and a bit more
readable. Consistently name the ioctl number
macros with "_32" and the compatibility stuctures
with "_compat." Rename the helpers which simply
copy in the arg with "_copyin" for easy identification.
Finally, for a few of the existing helpers, modify them
so that they directly call the native ioctl helper
after userspace argument fixup.
Signed-off-by: Eric Sandeen <sandeen@sandeen•net>
Reviewed-by: Christoph Hellwig <hch@lst•de>
Signed-off-by: Lachlan McIlroy <lachlan@sgi•com>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k•org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2008-12-04 9:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-03 7:36 linux-next: Tree for December 3 Stephen Rothwell
2008-12-03 12:41 ` next-20081203 build failure, when building xfs_file.o Kamalesh Babulal
2008-12-03 12:55 ` Christoph Hellwig
2008-12-03 14:15 ` Kamalesh Babulal
2008-12-03 19:49 ` m68k 8390 breakage (was: Re: linux-next: Tree for December 3) Geert Uytterhoeven
2008-12-03 19:56 ` Stephen Hemminger
2008-12-03 20:38 ` Geert Uytterhoeven
2008-12-04 6:18 ` m68k 8390 breakage David Miller
2008-12-03 21:16 ` linux-next: Tree for December 3 (media/video/cx88) Randy Dunlap
2008-12-06 10:10 ` Mauro Carvalho Chehab
2008-12-06 11:28 ` Mauro Carvalho Chehab
2008-12-04 1:30 ` [PATCH -next] rtc twl4030: rename ioctl function when RTC_INTF_DEV=n Randy Dunlap
2008-12-09 10:02 ` Alessandro Zummo
2008-12-04 1:33 ` linux-next: Tree for December 3 (MFD) Randy Dunlap
2008-12-07 20:22 ` Samuel Ortiz
2008-12-04 9:02 ` Geert Uytterhoeven [this message]
2008-12-04 12:13 ` XFS breakage on m68k (was: Re: linux-next: Tree for December 3) Christoph Hellwig
2008-12-04 12:46 ` Stephen Rothwell
2008-12-04 12:50 ` Christoph Hellwig
2008-12-04 13:23 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0812040956370.10635@anakin \
--to=geert@linux-m68k$(echo .)org \
--cc=hch@lst$(echo .)de \
--cc=lachlan@sgi$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sandeen@sandeen$(echo .)net \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=xfs@oss$(echo .)sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox