From: Greg KH <greg@kroah•com>
To: Geert Uytterhoeven <geert@linux-m68k•org>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
Song Chen <chensong_2000@189•cn>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: Re: linux-next: build failures after merge of the staging tree
Date: Mon, 4 Jan 2021 15:56:47 +0100 [thread overview]
Message-ID: <X/Msr8Dqbxk3YO0v@kroah.com> (raw)
In-Reply-To: <CAMuHMdXWqO2WPKSxsfbr=-_rrXenEwJRW3rYko7VJCPwCnyeLA@mail.gmail.com>
On Mon, Jan 04, 2021 at 09:27:01AM +0100, Geert Uytterhoeven wrote:
> On Mon, Jan 4, 2021 at 6:12 AM Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> > After merging the staging tree, today's linux-next build (arm
> > multi_v7_defconfig) failed like this:
> >
> > In file included from include/linux/printk.h:6,
> > from include/linux/kernel.h:16,
> > from drivers/staging/board/kzm9d.c:4:
> > drivers/staging/board/kzm9d.c:28:17: error: initialization of 'initcall_t' {aka 'int (*)(void)'} from incompatible pointer type 'void (*)(void)' [-Werror=incompatible-pointer-types]
> > 28 | device_initcall(kzm9d_init);
> > | ^~~~~~~~~~
> > include/linux/init.h:197:50: note: in definition of macro '___define_initcall'
> > 197 | __attribute__((__section__(#__sec ".init"))) = fn;
> > | ^~
> > include/linux/init.h:229:30: note: in expansion of macro '__define_initcall'
> > 229 | #define device_initcall(fn) __define_initcall(fn, 6)
> > | ^~~~~~~~~~~~~~~~~
> > drivers/staging/board/kzm9d.c:28:1: note: in expansion of macro 'device_initcall'
> > 28 | device_initcall(kzm9d_init);
> > | ^~~~~~~~~~~~~~~
> > cc1: some warnings being treated as errors
> > In file included from include/linux/printk.h:6,
> > from include/linux/kernel.h:16,
> > from include/asm-generic/bug.h:20,
> > from arch/arm/include/asm/bug.h:60,
> > from include/linux/bug.h:5,
> > from include/linux/thread_info.h:12,
> > from include/asm-generic/current.h:5,
> > from ./arch/arm/include/generated/asm/current.h:1,
> > from include/linux/sched.h:12,
> > from include/linux/ratelimit.h:6,
> > from include/linux/dev_printk.h:16,
> > from include/linux/device.h:15,
> > from include/linux/dma-mapping.h:7,
> > from drivers/staging/board/armadillo800eva.c:12:
> > drivers/staging/board/armadillo800eva.c:90:17: error: initialization of 'initcall_t' {aka 'int (*)(void)'} from incompatible pointer type 'void (*)(void)' [-Werror=incompatible-pointer-types]
> > 90 | device_initcall(armadillo800eva_init);
> > | ^~~~~~~~~~~~~~~~~~~~
> > include/linux/init.h:197:50: note: in definition of macro '___define_initcall'
> > 197 | __attribute__((__section__(#__sec ".init"))) = fn;
> > | ^~
> > include/linux/init.h:229:30: note: in expansion of macro '__define_initcall'
> > 229 | #define device_initcall(fn) __define_initcall(fn, 6)
> > | ^~~~~~~~~~~~~~~~~
> > drivers/staging/board/armadillo800eva.c:90:1: note: in expansion of macro 'device_initcall'
> > 90 | device_initcall(armadillo800eva_init);
> > | ^~~~~~~~~~~~~~~
> >
> > Caused by commit
> >
> > 850c35bb28ec ("staging: board: Remove macro board_staging")
> >
> > I have used the staging tree from next-20201223 for today.
>
> Note that a similar patch was (IMHO rightfully) rejected 3 years ago:
> https://lore.kernel.org/lkml/20170220175506.GA30142@kroah.com/
>
> So please drop it. Thanks!
Now reverted, thanks.
greg k-h
prev parent reply other threads:[~2021-01-04 14:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 1:26 linux-next: build failures after merge of the staging tree Stephen Rothwell
2021-01-04 8:27 ` Geert Uytterhoeven
2021-01-04 8:32 ` chensong_2000
2021-01-04 14:56 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/Msr8Dqbxk3YO0v@kroah.com \
--to=greg@kroah$(echo .)com \
--cc=chensong_2000@189$(echo .)cn \
--cc=geert@linux-m68k$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox