Subject: Re: linux-next: build warning after merge of the driver-core tree

From: Bagas Sanjaya <[email-masked]>
Date: Mon, 20 Feb 2023 16:49:48 +0700

On Mon, Feb 20, 2023 at 08:31:58AM +0100, Greg KH wrote:
> On Mon, Feb 20, 2023 at 03:26:41PM +0800, Qi Zheng wrote:
> > 
> > 
> > On 2023/2/20 13:31, Stephen Rothwell wrote:
> > > Hi all,
> > > 
> > > After merging the driver-core tree, today's linux-next build
> > > (htmldocs) produced this warning:
> > > 
> > > Documentation/filesystems/api-summary:146: fs/debugfs/inode.c:804: WARNING: Inline literal start-string without end-string.
> > > 
> > > Introduced by commit
> > > 
> > >    d3002468cb5d ("debugfs: update comment of debugfs_rename()")
> > 
> > This is just a comment modification. Didn't see where my modification
> > caused this WARNING. :(
> 
> Yeah, I don't understand either, here's the diff, what's wrong with it?
> 
> 
> --- a/fs/debugfs/inode.c
> +++ b/fs/debugfs/inode.c
> @@ -802,8 +802,8 @@ EXPORT_SYMBOL_GPL(debugfs_lookup_and_remove);
>   * exist for rename to succeed.
>   *
>   * This function will return a pointer to old_dentry (which is updated to
> - * reflect renaming) if it succeeds. If an error occurs, %NULL will be
> - * returned.
> + * reflect renaming) if it succeeds. If an error occurs, %ERR_PTR(-ERROR)
> + * will be returned.
>   *
>   * If debugfs is not enabled in the kernel, the value -%ENODEV will be
>   * returned.

Hi Greg and Qi,

The simple fix is to drop the percent (which is an inline code variant):

---- >8 ----
diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
index 58a35afb7c5d89..a7a6a0821605a8 100644
--- a/fs/debugfs/inode.c
+++ b/fs/debugfs/inode.c
@@ -802,7 +802,7 @@ EXPORT_SYMBOL_GPL(debugfs_lookup_and_remove);
  * exist for rename to succeed.
  *
  * This function will return a pointer to old_dentry (which is updated to
- * reflect renaming) if it succeeds. If an error occurs, %ERR_PTR(-ERROR)
+ * reflect renaming) if it succeeds. If an error occurs, ERR_PTR(-ERROR)
  * will be returned.
  *
  * If debugfs is not enabled in the kernel, the value -%ENODEV will be

Thanks.

-- 
An old man doll... just what I always wanted! - Clara