From: "Luck, Tony" <tony.luck@intel•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Greg KH <gregkh@linuxfoundation•org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: Re: [PATCH v2] topology/sysfs: Fix allnoconfig build breakage.
Date: Thu, 21 Apr 2022 19:51:02 -0700 [thread overview]
Message-ID: <YmIYFjI/B+33PQn+@agluck-desk3.sc.intel.com> (raw)
In-Reply-To: <20220422100054.74cadded@canb.auug.org.au>
On Fri, Apr 22, 2022 at 10:00:54AM +1000, Stephen Rothwell wrote:
> I assume that there is some good reason that topology_ppin() is not
> implemented as a static inline function?
I don't think so. I just cut & pasted how all the other topology_*()
things were implemented.
Making it a static inline appears to fix this problem. But before
embarrassing myself with a third broken version I'll let zero day
crunch on:
git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux.git hide_ppin
to see if there is some subtle config or arch where the inline trick
doesn't work.
Thanks for the idea! :-)
-Tony
next prev parent reply other threads:[~2022-04-22 2:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 5:26 linux-next: build warning after merge of the driver-core.current tree Stephen Rothwell
2022-04-21 6:49 ` Greg KH
2022-04-21 15:45 ` [PATCH] topology/sysfs: Fix allnoconfig build breakage Luck, Tony
2022-04-21 15:53 ` Greg KH
2022-04-21 16:19 ` [PATCH v2] " Luck, Tony
2022-04-21 23:22 ` Stephen Rothwell
2022-04-21 23:38 ` Luck, Tony
2022-04-22 0:00 ` Stephen Rothwell
2022-04-22 2:51 ` Luck, Tony [this message]
2022-04-22 6:00 ` Greg KH
2022-04-22 6:27 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmIYFjI/B+33PQn+@agluck-desk3.sc.intel.com \
--to=tony.luck@intel$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox