From: Matthew Wilcox <willy@infradead•org>
To: Ryusuke Konishi <konishi.ryusuke@gmail•com>
Cc: Andrew Morton <akpm@linux-foundation•org>,
Stephen Rothwell <sfr@canb•auug.org.au>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>,
Yang Li <yang.lee@linux•alibaba.com>
Subject: Re: linux-next: manual merge of the mm tree with the folio tree
Date: Thu, 12 May 2022 13:51:03 +0100 [thread overview]
Message-ID: <Yn0Ct66Ww44HDj7S@casper.infradead.org> (raw)
In-Reply-To: <CAKFNMokFYi4AGd8+B6sT73Pu9k_bAu53-d_u1=0fsiHbz3Jgxg@mail.gmail.com>
On Thu, May 12, 2022 at 08:52:17PM +0900, Ryusuke Konishi wrote:
> On Thu, May 12, 2022 at 5:26 PM Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> >
> > Hi all,
> >
> > Today's linux-next merge of the mm tree got a conflict in:
> >
> > fs/nilfs2/inode.c
> >
> > between commit:
> >
> > f132ab7d3ab0 ("fs: Convert mpage_readpage to mpage_read_folio")
> >
> > from the folio tree and commit:
> >
> > e38ed506c42f ("nilfs2: Fix some kernel-doc comments")
> >
> > from the mm tree.
> >
> > I fixed it up (see below) and can carry the fix as necessary. This
> > is now fixed as far as linux-next is concerned, but any non trivial
> > conflicts should be mentioned to your upstream maintainer when your tree
> > is submitted for merging. You may also want to consider cooperating
> > with the maintainer of the conflicting tree to minimise any particularly
> > complex conflicts.
>
> Thanks, Stephen.
>
> Andrew, please once drop
>
> e38ed506c42f ("nilfs2: Fix some kernel-doc comments")
>
> from -mm tree. I will resend a modified patch after the folio patch is merged
> to the mainline.
I'd be happy to take this patch through my tree instead, if you point me
to where I can pick it up (I don't see it on fsdevel or mm).
Although I do think we need to consider whether implementations of
fs entry points (aops, fops, iops, etc) should have documentation in
the individual filesystems. I understand why individual filesystem
authors want that, but it would be better if we had really
good central documentation of VFS/FS requirements (and honestly
Documentation/filesystems/{locking.rst,vfs.rst} aren't bad) instead of
reiterating them in each individual filesystem.
next prev parent reply other threads:[~2022-05-12 12:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 8:26 linux-next: manual merge of the mm tree with the folio tree Stephen Rothwell
2022-05-12 11:52 ` Ryusuke Konishi
2022-05-12 12:51 ` Matthew Wilcox [this message]
2022-05-12 16:13 ` Ryusuke Konishi
-- strict thread matches above, loose matches on Subject: below --
2022-06-22 5:38 Stephen Rothwell
2022-06-22 7:22 ` Muchun Song
2022-06-22 18:59 ` Andrew Morton
2022-06-23 2:15 ` Muchun Song
2022-06-20 3:53 Stephen Rothwell
2022-05-03 6:14 Stephen Rothwell
2022-05-02 9:36 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yn0Ct66Ww44HDj7S@casper.infradead.org \
--to=willy@infradead$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=konishi.ryusuke@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=yang.lee@linux$(echo .)alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox