From: Zev Weiss <zev@bewilderbeest•net>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Guenter Roeck <linux@roeck-us•net>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: Re: linux-next: build warning after merge of the hwmon-staging tree
Date: Tue, 10 May 2022 03:47:06 -0700 [thread overview]
Message-ID: <YnpCqh9+koMal9sD@hatter.bewilderbeest.net> (raw)
In-Reply-To: <20220510201104.06eead74@canb.auug.org.au>
On Tue, May 10, 2022 at 03:11:04AM PDT, Stephen Rothwell wrote:
> Hi all,
>
> After merging the hwmon-staging tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
>
> WARNING: unmet direct dependencies detected for SENSORS_NCT6775
> Depends on [n]: HWMON [=y] && !PPC [=y] && (ACPI_WMI [=n] || ACPI_WMI [=n]=n)
> Selected by [y]:
> - SENSORS_NCT6775_I2C [=y] && HWMON [=y] && I2C [=y]
>
> Probably introduced by commit
>
> 58f1d9ebfce6 ("hwmon: (nct6775) Add i2c driver")
>
Ah -- yes, thanks. The Kconfig symbols in that patch series underwent
some changes between revisions during review and I missed a couple of
places that should have been updated. I believe the patch below should
fix it.
Thanks,
Zev
From 817067c631ca7c7537be4bd18b0c9b5d2b735e54 Mon Sep 17 00:00:00 2001
From: Zev Weiss <zev@bewilderbeest•net>
Date: Tue, 10 May 2022 03:22:20 -0700
Subject: [PATCH] hwmon: (nct6775) Fix Kconfig references in
SENSORS_NCT6775_I2C
In the process of renaming some Kconfig symbols during the review
process a couple of updates got omitted. Make the i2c driver select
the correct dependency (the core module, not the platform driver), and
refer to the intended symbol for the platform driver in its help text.
Signed-off-by: Zev Weiss <zev@bewilderbeest•net>
---
drivers/hwmon/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index fe49dccf16bf..590d3d550acb 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -1506,7 +1506,7 @@ config SENSORS_NCT6775_I2C
tristate "I2C driver for Nuvoton NCT6775F and compatibles"
depends on I2C
select REGMAP_I2C
- select SENSORS_NCT6775
+ select SENSORS_NCT6775_CORE
help
If you say yes here you get support for the hardware monitoring
functionality of the Nuvoton NCT6106D, NCT6775F, NCT6776F, NCT6779D,
@@ -1514,7 +1514,7 @@ config SENSORS_NCT6775_I2C
Super-I/O chips via their I2C interface.
If you're not building a kernel for a BMC, this is probably
- not the driver you want (see CONFIG_SENSORS_NCT6775_PLATFORM).
+ not the driver you want (see CONFIG_SENSORS_NCT6775).
This driver can also be built as a module. If so, the module
will be called nct6775-i2c.
--
2.36.0
next prev parent reply other threads:[~2022-05-10 10:47 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 10:11 linux-next: build warning after merge of the hwmon-staging tree Stephen Rothwell
2022-05-10 10:47 ` Zev Weiss [this message]
2022-05-10 14:03 ` Guenter Roeck
-- strict thread matches above, loose matches on Subject: below --
2026-01-13 4:54 Stephen Rothwell
2025-11-18 2:44 Stephen Rothwell
2025-11-19 5:25 ` Guenter Roeck
2025-09-08 8:07 Stephen Rothwell
2025-09-08 8:06 Stephen Rothwell
2025-03-18 10:35 Stephen Rothwell
2025-03-18 15:04 ` Guenter Roeck
2024-12-16 4:58 Stephen Rothwell
2024-03-26 5:03 Stephen Rothwell
2023-12-12 3:12 Stephen Rothwell
2023-12-12 5:11 ` Guenter Roeck
2023-10-30 5:15 Stephen Rothwell
2022-08-31 5:30 Stephen Rothwell
2022-05-03 7:22 Stephen Rothwell
2022-05-03 7:34 ` Michael Walle
2022-05-03 13:08 ` Guenter Roeck
2022-02-10 7:51 Stephen Rothwell
2022-02-10 8:50 ` Lee Jones
2022-02-10 17:33 ` Guenter Roeck
2022-02-10 18:07 ` Lee Jones
2022-02-10 18:22 ` Guenter Roeck
2022-02-04 5:16 Stephen Rothwell
2022-02-04 5:25 ` Guenter Roeck
2021-12-20 11:31 Stephen Rothwell
2021-12-20 0:00 Stephen Rothwell
2021-06-10 0:21 Stephen Rothwell
2021-06-10 3:38 ` Guenter Roeck
2021-03-30 7:27 Stephen Rothwell
2021-03-30 10:38 ` Guenter Roeck
2021-03-30 20:25 ` Chris Packham
2021-03-30 20:55 ` Guenter Roeck
2021-03-12 3:50 Stephen Rothwell
2021-03-12 4:00 ` Chris Packham
2021-03-12 4:45 ` Stephen Rothwell
2021-01-29 7:03 Stephen Rothwell
2020-12-07 7:51 Stephen Rothwell
2020-11-30 0:56 Stephen Rothwell
2020-11-30 1:14 ` Paul Barker
2020-11-30 14:53 ` Guenter Roeck
2020-02-10 22:23 Stephen Rothwell
2020-02-11 0:24 ` Guenter Roeck
2019-07-01 2:26 Stephen Rothwell
2019-06-06 0:34 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnpCqh9+koMal9sD@hatter.bewilderbeest.net \
--to=zev@bewilderbeest$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux@roeck-us$(echo .)net \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox