From: Sakari Ailus <sakari.ailus@linux•intel.com>
To: Randy Dunlap <rdunlap@infradead•org>
Cc: linux-media@vger•kernel.org,
Stephen Rothwell <sfr@canb•auug.org.au>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
linux-next@vger•kernel.org, Wentong Wu <wentong.wu@intel•com>,
Zhifeng Wang <zhifeng.wang@intel•com>,
Mauro Carvalho Chehab <mchehab@kernel•org>
Subject: Re: [PATCH 1/2] media: v4l: usb: Use correct dependency for camera sensor drivers
Date: Fri, 18 Aug 2023 09:47:13 +0000 [thread overview]
Message-ID: <ZN8+IQheaChc3Ks+@kekkonen.localdomain> (raw)
In-Reply-To: <363d77a7-ee1a-f4c4-941a-7737568a8042@infradead.org>
Hi Randy,
On Wed, Aug 16, 2023 at 12:21:31PM -0700, Randy Dunlap wrote:
> Hi Sakari,
>
> On 8/16/23 06:35, Sakari Ailus wrote:
> > The Kconfig option that enables compiling camera sensor drivers is
> > VIDEO_CAMERA_SENSOR rather than MEDIA_CAMERA_SUPPORT as it was previously.
> > Fix this.
> >
> > Reported-by: Randy Dunlap <rdunlap@infradead•org>
> > Fixes: 7d3c7d2a2914 ("media: i2c: Add a camera sensor top level menu")
> > Signed-off-by: Sakari Ailus <sakari.ailus@linux•intel.com>
> > ---
> > drivers/media/usb/em28xx/Kconfig | 4 ++--
> > drivers/media/usb/go7007/Kconfig | 2 +-
> > 2 files changed, 3 insertions(+), 3 deletions(-)
> >
>
> This patch reduces the number of kconfig warnings from 4 to 2. I still see these
> (and these appear to be duplicates, so only one):
>
> WARNING: unmet direct dependencies detected for VIDEO_OV7670
> Depends on [n]: MEDIA_SUPPORT [=y] && VIDEO_DEV [=y] && VIDEO_CAMERA_SENSOR [=n]
> Selected by [y]:
> - VIDEO_MMP_CAMERA [=y] && MEDIA_SUPPORT [=y] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && V4L_PLATFORM_DRIVERS [=y] && I2C [=y] && VIDEO_DEV [=y] && (ARCH_MMP || COMPILE_TEST [=y]) && COMMON_CLK [=y]
>
> WARNING: unmet direct dependencies detected for VIDEO_OV7670
> Depends on [n]: MEDIA_SUPPORT [=y] && VIDEO_DEV [=y] && VIDEO_CAMERA_SENSOR [=n]
> Selected by [y]:
> - VIDEO_MMP_CAMERA [=y] && MEDIA_SUPPORT [=y] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && V4L_PLATFORM_DRIVERS [=y] && I2C [=y] && VIDEO_DEV [=y] && (ARCH_MMP || COMPILE_TEST [=y]) && COMMON_CLK [=y]
Oops. I missed this bit.
Hans has taken the ivsc Kconfig patch already so I'll send v2 for this one
only.
--
Regards,
Sakari Ailus
next prev parent reply other threads:[~2023-08-18 9:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 13:35 [PATCH 0/2] Media Kconfig fixes Sakari Ailus
2023-08-16 13:35 ` [PATCH 1/2] media: v4l: usb: Use correct dependency for camera sensor drivers Sakari Ailus
2023-08-16 19:21 ` Randy Dunlap
2023-08-18 9:47 ` Sakari Ailus [this message]
2023-08-16 13:35 ` [PATCH 2/2] media: ivsc: Add ACPI dependency Sakari Ailus
2023-08-16 19:21 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZN8+IQheaChc3Ks+@kekkonen.localdomain \
--to=sakari.ailus@linux$(echo .)intel.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mchehab@kernel$(echo .)org \
--cc=rdunlap@infradead$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=wentong.wu@intel$(echo .)com \
--cc=zhifeng.wang@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox