Subject: Re: linux-next: build failure after merge of the crypto tree

From: Herbert Xu <[email-masked]>
Date: Wed, 13 Mar 2024 09:43:52 +0800

On Wed, Mar 13, 2024 at 11:57:51AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the crypto tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> In file included from mm/zswap.c:30:
> include/crypto/acompress.h: In function 'acomp_is_async':
> include/crypto/acompress.h:124:16: error: implicit declaration of function 'crypto_comp_alg_common'; did you mean 'crypto_tfm_alg_name'? [-Werror=implicit-function-declaration]
>   124 |         return crypto_comp_alg_common(tfm)->base.cra_flags &
>       |                ^~~~~~~~~~~~~~~~~~~~~~
>       |                crypto_tfm_alg_name
> include/crypto/acompress.h:124:43: error: invalid type argument of '->' (have 'int')
>   124 |         return crypto_comp_alg_common(tfm)->base.cra_flags &
>       |                                           ^~
> include/crypto/acompress.h:126:1: error: control reaches end of non-void function [-Werror=return-type]
>   126 | }
>       | ^
> cc1: some warnings being treated as errors
> 
> Caused by commit
> 
>   86464db929ca ("crypto: introduce: acomp_is_async to expose if comp drivers might sleep")

Instead of using the non-existent crypto_comp_alg_common, it
should do something like

		return crypto_acomp_tfm(tfm)->__crt_alg->cra_flags & ...

Thanks,
-- 
Email: Herbert Xu <[email-masked]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt