From: "Alexander Beregalov" <a.beregalov@gmail•com>
To: Jens Axboe <jens.axboe@oracle•com>,
Stephen Rothwell <sfr@canb•auug.org.au>,
Thomas Gleixner <tglx@linutronix•de>,
Mike Anderson <andmike@linux•vnet.ibm.com>,
James Bottomle
Subject: Re: next-20081119: general protection fault: get_next_timer_interrupt()
Date: Tue, 25 Nov 2008 20:14:30 +0300 [thread overview]
Message-ID: <a4423d670811250914x3a42e56egd1bf06e6229666ba@mail.gmail.com> (raw)
In-Reply-To: <20081125165955.GB529@us.ibm.com>
2008/11/25 <malahal@us•ibm.com>:
> Jens Axboe [jens.axboe@oracle•com] wrote:
>> On Mon, Nov 24 2008, malahal@us•ibm.com wrote:
>> > Stephen Rothwell [sfr@canb•auug.org.au] wrote:
>> > > > The block timer code calls del_timer(), should it call del_timer_sync()?
>> > > > It is possible although unlikely that you are hitting del_timer_sync vs
>> > > > del_timer problem in the block timeout code. Can only be seen on SMP
>> > > > systems though!
>> > >
>> > > Is this still a problem in next-20081121? In that tree, the block commit
>> > > "block: leave the request timeout timer running even on an empty list"
>> > > was changed to add this:
>> > >
>> > > diff --git a/block/blk-core.c b/block/blk-core.c
>> > > index 04267d6..44f547c 100644
>> > > --- a/block/blk-core.c
>> > > +++ b/block/blk-core.c
>> > > @@ -391,6 +391,7 @@ EXPORT_SYMBOL(blk_stop_queue);
>> > > void blk_sync_queue(struct request_queue *q)
>> > > {
>> > > del_timer_sync(&q->unplug_timer);
>> > > + del_timer_sync(&q->timeout);
>> > > kblockd_flush_work(&q->unplug_work);
>> > > }
>> > > EXPORT_SYMBOL(blk_sync_queue);
>> >
>> > I was looking at the Linux tree. Clearly same problem doesn't exist with
>> > the above commit! I wonder why kblockd_flush_work() is called after the
>> > del_timer_sync(). It makes sense to cancel the work and then shutdown
>> > the timer(s). I doubt if you are running into this problem though.
>>
>> If the kernel tested doesn't include the above fix, it'll surely go
>> boom. Can someone verify that this is the case?
>
> Just looked, next-20081119 doesn't have the above fix. It is included in
> next-20081120. Also note that the above fix is only partially copied,
> there is other part that removed deleting the timer when there are no
> outstanding requests.
>
Yes, I can not reproduce it anymore on linux-next 1121 and newer. (I
did not try 1120)
It seems the fix works pretty good.
Is it still needed and reasonable to investigate the problem on next-20081119?
Unfortunately I do not have much time for it.
All these problems have gone away on next-1125 except ODEBUG warning on HPET.
next prev parent reply other threads:[~2008-11-25 17:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-19 15:14 next-20081119: general protection fault: get_next_timer_interrupt() Alexander Beregalov
2008-11-19 21:14 ` Thomas Gleixner
2008-11-21 10:50 ` Alexander Beregalov
2008-11-24 17:43 ` Thomas Gleixner
2008-11-24 19:15 ` James Bottomley
2008-11-24 19:31 ` Thomas Gleixner
2008-11-24 21:35 ` Mike Anderson
2008-11-24 22:33 ` Thomas Gleixner
2008-11-24 23:42 ` malahal
2008-11-25 0:09 ` malahal
2008-11-25 0:57 ` Stephen Rothwell
2008-11-25 2:08 ` malahal
2008-11-25 8:51 ` Jens Axboe
2008-11-25 16:59 ` malahal
2008-11-25 17:14 ` Alexander Beregalov [this message]
2008-11-25 17:43 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4423d670811250914x3a42e56egd1bf06e6229666ba@mail.gmail.com \
--to=a.beregalov@gmail$(echo .)com \
--cc=andmike@linux$(echo .)vnet.ibm.com \
--cc=jens.axboe@oracle$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=tglx@linutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox